Add Archlinux support #25

PrzemekSkw · 2023-02-07T19:52:24Z

It will be great if someone make AUR package.

Regards.

rhysperry111 · 2023-02-08T10:29:45Z

Just working on a PKGBUILD right now (the one in the makedeb dir confused me until I realised that makedeb was a weird debian tool :P, and also debian dependencies look like hell lmao).

In the deb version, libayatana-appindicator is used, but there's also libappindicator-gtk3 which was already installed on my system. Does @hwittenborn have a preference over which is used?

Another point is that currently I cannot build because of a module called file-lock, so I am currently waiting on alfiedotwtf/file-lock#6 (this is why I'm personally fan of the traditional distribution-managed dependency systems rather than the huge dep trees that get pulled with tools like cargo, pip and npm :P)

Got the file-lock error fixed with the help of upstream, now I'm waiting on help with a build error in sea-orm.

yochananmarqos · 2023-02-08T14:04:02Z

I have a PKGBUILD in progress, but it's currently failing to build due to something with sqlx:

Log

   Compiling sqlx v0.6.2
error: /build/celeste/src/celeste-0.3.5/target/release/deps/libsqlx_macros-5093f6dbb26cf4ea.so: undefined symbol: sqlite3_unlock_notify
  --> /build/.cargo/registry/src/github.com-1ecc6299db9ec823/sqlx-0.6.2/src/lib.rs:67:1
   |
67 | pub extern crate sqlx_macros;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0432]: unresolved imports `self::encode::Encode`, `self::decode::Decode`, `super::Decode`, `super::Encode`, `super::FromRow`, `super::Type`
   --> /build/.cargo/registry/src/github.com-1ecc6299db9ec823/sqlx-0.6.2/src/lib.rs:126:9
    |
126 | pub use self::encode::Encode;
    |         ^^^^^^^^^^^^^^^^^^^^
...
137 | pub use self::decode::Decode;
    |         ^^^^^^^^^^^^^^^^^^^^
...
151 |     pub use super::Decode;
    |             ^^^^^^^^^^^^^
152 |     pub use super::Encode;
    |             ^^^^^^^^^^^^^
153 |     pub use super::Executor;
154 |     pub use super::FromRow;
    |             ^^^^^^^^^^^^^^
...
158 |     pub use super::Type;
    |             ^^^^^^^^^^^

For more information about this error, try `rustc --explain E0432`.
error: could not compile `sqlx` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: Recipe `build` failed on line 3 with exit code 101

hwittenborn · 2023-02-08T14:07:38Z

@rhysperry111 I was looking at that issue you linked - do you need Celeste to update the version of it's dependencies?

In the deb version, libayatana-appindicator is used, but there's also libappindicator-gtk3 which was already installed on my system. Does @hwittenborn have a preference over which is used?

No you should be able to use either, I might add to makedeb's PKGBUILD to allow either too.

rhysperry111 · 2023-02-08T14:33:56Z

@rhysperry111 I was looking at that issue you linked - do you need Celeste to update the version of it's dependencies?

It would probably help. I'm not too familiar with cargo, but it was being awfully stubborn about changing versions.

No you should be able to use either, I might add to makedeb's PKGBUILD to allow either too.

Cool.

I'm still having trouble getting sea-orm to compile though.

   Compiling sea-orm v0.10.7
error[E0658]: generic associated types are unstable
  --> /home/rhys/.cargo/registry/src/github.com-1ecc6299db9ec823/sea-orm-0.10.7/src/database/connection.rs:39:5
   |
39 | /     type Stream<'a>: Stream<Item = Result<QueryResult, DbErr>> + Send
40 | |     where
41 | |         Self: 'a;
   | |_________________^
   |
   = note: see issue #44265 <https://github.com/rust-lang/rust/issues/44265> for more information
   = help: add `#![feature(generic_associated_types)]` to the crate attributes to enable

error[E0658]: where clauses on associated types are unstable
  --> /home/rhys/.cargo/registry/src/github.com-1ecc6299db9ec823/sea-orm-0.10.7/src/database/connection.rs:39:5
   |
39 | /     type Stream<'a>: Stream<Item = Result<QueryResult, DbErr>> + Send
40 | |     where
41 | |         Self: 'a;
   | |_________________^
   |
   = note: see issue #44265 <https://github.com/rust-lang/rust/issues/44265> for more information
   = help: add `#![feature(generic_associated_types)]` to the crate attributes to enable

error[E0658]: generic associated types are unstable
   --> /home/rhys/.cargo/registry/src/github.com-1ecc6299db9ec823/sea-orm-0.10.7/src/database/db_connection.rs:169:5
    |
169 |     type Stream<'a> = crate::QueryStream;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #44265 <https://github.com/rust-lang/rust/issues/44265> for more information
    = help: add `#![feature(generic_associated_types)]` to the crate attributes to enable

error[E0658]: generic associated types are unstable
   --> /home/rhys/.cargo/registry/src/github.com-1ecc6299db9ec823/sea-orm-0.10.7/src/database/transaction.rs:421:5
    |
421 |     type Stream<'a> = TransactionStream<'a>;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #44265 <https://github.com/rust-lang/rust/issues/44265> for more information
    = help: add `#![feature(generic_associated_types)]` to the crate attributes to enable

error: internal compiler error: compiler/rustc_middle/src/ty/subst.rs:554:13: Region parameter out of range when substituting in region 'b (index=5)

Guessing part of the problem is that cargo-nightly in the Arch repos hasn't been updated since 01 Nov 2022 (seems to be a mirror issue - working on it :P)

hwittenborn · 2023-02-08T17:26:42Z

do you need Celeste to update the version of it's dependencies?

It would probably help.

I can get that done when I push some other changes tonight.

Guessing part of the problem is that cargo-nightly in the Arch repos hasn't been updated since 01 Nov 2022 (seems to be a mirror issue - working on it :P)

You should be able to just require rustup as a dependency, is there any reason that wouldn't work?

yochananmarqos · 2023-02-08T17:31:31Z

@rhysperry111 @hwittenborn cargo-nightly isn't a package, rustup provides it.

rhysperry111 · 2023-02-08T17:39:21Z

I've got a working PKGBUILD now, just need to finish up a few things. I saw rclone was included as a dep but it seems to run fine on my side without it. Should I just include it as an optional dep?

hwittenborn · 2023-02-08T18:04:28Z

I saw rclone was included as a dep but it seems to run fine on my side without it.

It's needed to log in to Google Drive and Dropbox servers, and more in the future once they get added, so I'd make it required.

hwittenborn · 2023-02-08T18:07:43Z

Any idea what changed for the thing @yochananmarqos mentioned @rhysperry111?

rhysperry111 · 2023-02-08T18:10:16Z

Not too sure. A bunch of my issues came from the fact I had an outdated rustc. I had to delete ~/.rustup to get it to pull a new version.

yochananmarqos · 2023-02-08T18:19:54Z

@rhysperry111 Build in a clean chroot.

yochananmarqos · 2023-02-08T21:04:41Z

I've got a working PKGBUILD now

@rhysperry111

Show me, don't tell me

-- Show Don't Tell, Rush

😜

rhysperry111 · 2023-02-08T21:50:58Z

pkgname=celeste-git
_name=celeste
pkgver=0.3.5.r2.gb87b8a0
pkgrel=1
pkgdesc='GUI file synchronization client that can sync with any cloud provider'
arch=('any')
url='https://github.com/hwittenborn/celeste.git'
license=('GPL3')
depends=('rclone' 'gtk4' 'libadwaita')
makedepends=('cargo-nightly' 'just' 'go' 'gtk3' 'libappindicator-gtk3' 'clang')
provides=('celeste')
source=('git+https://github.com/hwittenborn/celeste.git')
sha256sums=('SKIP')

pkgver() {
    cd "${_name}"
    git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
}

build() {
    cd "${_name}"
    just build
}

package() {
    cd "${_name}"
    DESTDIR="${pkgdir}/" just install
}

On my system, it seemed that gtk4 was a run-time dep whereas gtk3 was only needed at compile time (which is the opposite of the makedeb package), and it also seemed that libappindicator-gtk3 wasn't needed at runtime at all, but since I currently don't have a chroot setup it's a little hard to verify the deps properly.

Other than that though, this works for me

yochananmarqos · 2023-02-08T22:02:58Z

I have no idea how it's working for you as I'm still receiving the same build error for sqlx as I mentioned above. I tried the latest commit just in case, but the last two commits since the release tag are not related to the build process.

Are you using the latest nightly toolchain?

info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2023-02-08, rust version 1.69.0-nightly (bd39bbb4b 2023-02-07)

It really makes no sense to need both gtk3 and gtk4. It's one or the other. Since I cannot complete the build, I can't verify the final runtime dependencies.

Also, only one tray icon implementation should be chosen. Neither Ayatana nor Appindicator are required to build as far as I've noticed so far.

rhysperry111 · 2023-02-08T22:28:09Z

Yeah I'm on the latest toolchain (cargo 1.69.0-nightly, rustup 1.25.2, rustc 1.69.0-nightly)

hwittenborn · 2023-02-08T23:37:17Z

On my system, it seemed that gtk4 was a run-time dep whereas gtk3 was only needed at compile time

I know the header files for both are needed at least to compile, though I don't know if arch splits development packages and normal packages like Debian/Ubuntu based distros do. The tray application (mentioned below) is embedded into the celeste binary, so you probably won't get any missing library errors from any linting tools, if that's how you're finding out. The tray application does use GTK3 library material though, so it shouldn't be able to run without it. If you can get it working without it though feel free to leave it out for now, it can always be added later if users complain or anything like that.

It really makes no sense to need both gtk3 and gtk4.

The main application is written in GTK4/Libadwaita, but GTK4 doesn't have appindicator support, so it's a separate application written in GTK3.

hwittenborn · 2023-02-08T23:42:44Z

Also:

it seemed that gtk4 was a run-time dep whereas gtk3 was only needed at compile time (which is the opposite of the makedeb package)

gtk4 is also a runtime dependency in the makedeb package, libadwaita-1-0 just also depends on gtk4 so it ends up installing it if it isn't already in the process.

I don't know what tools you guys are familiar with, but the way I found missing dependencies was to do a fresh build in a Docker container, and then as missing dependencies popped up I just searched for the missing files with apt-file. I think there exists a similar tool for Arch Linux to find what packages contain certain files, but I don't remember the name of it off the top of my head.

yochananmarqos · 2023-02-08T23:43:06Z

The main application is written in GTK4/Libadwaita, but GTK4 doesn't have appindicator support, so it's a separate application written in GTK3.

I see. Nicotine+ has a tray icon with GTK4. I can't remember what the implementation is called now, but I noticed they just removed some old GtkStatusIcon code yesterday.

As far as finding dependencies, I build in a clean chroot and use trial and error like you mentioned.

On Arch, one would use pacman -Fx <search term>; i.e.,

❯ pacman -Fx gdk-3.0
extra/gtk3 1:3.24.36-1 [installed]
    usr/lib/girepository-1.0/Gdk-3.0.typelib
    usr/lib/pkgconfig/gdk-3.0.pc
    usr/share/gir-1.0/Gdk-3.0.gir
extra/vala 0.56.3-1
    usr/share/vala-0.56/vapi/gdk-3.0.deps
    usr/share/vala-0.56/vapi/gdk-3.0.vapi
community/haskell-gi-gdk3 3.0.25-44
    usr/lib/libHSgi-gdk-3.0.25-3fIqjFN8DPPGmFJgc178N1-ghc9.0.2.so
multilib/lib32-gtk3 1:3.24.36-1 [installed]
    usr/lib32/pkgconfig/gdk-3.0.pc

hwittenborn · 2023-02-08T23:46:15Z

Nicotine++ has a tray icon with GTK4.

Wow, that's definitely something I'll look into. Currently the main application and the tray application communicate over a DBus connection, but it's been a pain to manage, so I'll see what I can find out from there a bit later.

yochananmarqos · 2023-02-08T23:48:52Z

You replied before I was finished editing my post. 😝 I'm done now.

I'm still a bit jet lagged from flying across the pond to FOSDEM and back this weekend. 🧟‍♂️

hwittenborn · 2023-02-08T23:53:21Z

Lol you're all good. Yeah, that looks like the right way to find the dependencies then, I guess it's just a matter of finding the right ones then.

I'm not quite sure what's up with your sqlx error - I don't have the latest version of rust installed from Rustup on my machine, but the CI always does and it's been doing fine the past few days. I'm about to publish a new release after I get an issue fixed, of which it'll run again though, so I'll be able to see if something's up then.

yochananmarqos · 2023-02-09T16:12:49Z

I was able to build 0.4.0 fine today. Turns out I needed to disable LTO, for one.

The dependencies appear to be:

depends=('cairo' 'gdk-pixbuf2' 'libadwaita' 'pango' 'rclone')
makedepends=('cargo-nightly' 'clang' 'go' 'gtk3' 'just')
optdepends=('libayatana-appindicator: option for tray icon'
            'libappindicator-gtk3: option for tray icon')

See my updated PKGBUILD.

I think we may be ready to add it to the AUR.

rhysperry111 · 2023-02-09T16:21:18Z

I don't believe that gdk-pixbuf2, cairo, or pango need to be specified as deps, as they are already pulled in by libadwaita (pactree libadwaita).

Other than that, it seems a little bit more complicated than mine, but I'm sure you have your reasons :P

yochananmarqos · 2023-02-09T16:49:22Z

Ah, good point. Just libadwaita and rclone should be enough then.

I've added it to the AUR: celeste. If anyone wants to help maintain it, let me know your username and I'll add you as a Co-Maintainer.

rhysperry111 · 2023-02-09T16:55:25Z

I wouldn't mind being added as a co-maintainer (same username here as I have everywhere). I won't be using it though until #9 comes through, as that's what I use for school.

FabioLolix · 2023-02-09T18:14:32Z

Hello people, celeste as package name already exist in some other repos and is a game

https://aur.archlinux.org/packages?O=0&SeB=n&K=celeste&outdated=&SB=p&SO=d&PP=50&submit=Go

https://repology.org/project/celeste/versions

Would you consider changing the package and bin to celeste-client or something else or no?

yochananmarqos · 2023-02-09T18:36:01Z

Well, celeste didn't already exist and the game may not be able to be built from source. If ever someone wants to claim celeste for the game, then we could change the package name at that time.

FabioLolix · 2023-02-09T18:51:21Z

While celeste for the game was not already used on the AUR having celeste and celeste-bin as 2 differents program will cause confusion

yochananmarqos · 2023-02-09T18:56:24Z

The package descriptions are different so it's obvious they are different things. This is not the first occurrence of projects with the same name in the AUR.

hwittenborn · 2023-02-09T19:25:38Z

I'd rather just take celeste for this project since it's available on the AUR. That's how the Snap and MPR packages already do it, so I don't see much of a problem with it.

yochananmarqos · 2023-02-09T19:38:06Z

@hwittenborn Well, that was my initial reasoning. Now that I look a little closer, I see that celeste-bin provides and conflicts with celeste. @FabioLolix has now added the binary release of this program as celeste-client-bin which unpacks the Snap. It also provides and conflicts with celeste. That will create an issue as folks will not be able to install the game and this program at the same time.

I could create celeste-client and submit a request to merge celeste into it. Then celeste-client-bin would no longer provide and conflict with celeste and the game and this program could be installed at the same time.

hwittenborn · 2023-02-09T20:00:23Z

That will create an issue as folks will not be able to install the game and this program at the same time.

It looks like they're always just going to conflict with each other - celeste-bin installs a file at /usr/bin/celeste, which this application also uses.

I could create celeste-client and submit a request to merge celeste into it.

Would that result in the final package being called celeste-client or celeste? I'd definitely prefer celeste but if you have to use something else, I'd probably go with celeste-sync just for the sake of clarity.

yochananmarqos · 2023-02-09T20:02:26Z

If I created celeste-client / celeste-sync, I could rename the binary to the same name as not to conflict with the game.

hwittenborn · 2023-02-09T20:06:39Z

That could work, the application probably wouldn't be launched from a CLI much anyway.

It looks like the AUR packages for the Celeste game aren't too popular yet though, so I think if we could use celeste that we should definitely take up the opportunity. There weren't really packages for the game on Repology either, and even those that are weren't using the celeste package name (they were under the namespace games-rpg/ for the Gentoo and LiGurOS packages, and everything else was just named differently).

rhysperry111 · 2023-02-09T20:12:01Z

It might be worth just asking the people packaging the game if the could change the binary name. It's obviously up to them since they got the name first, but I feel like there shouldn't be too much of a problem, especially considering the potential for this program in the future.

hwittenborn · 2023-02-13T14:22:25Z

What's the status of this? I'd love to add instructions to the README for installing Celeste from the AUR if y'all would be down with it.

yochananmarqos · 2023-02-13T18:58:57Z

You said you were fine with the package being called celeste, so I haven't done anything.

PrzemekSkw · 2023-02-13T19:50:39Z

Great @rhysperry111 . Thank You very much. I'm very grateful and wish I could help but I don't know much about packing in AUR.

hwittenborn · 2023-02-13T19:54:32Z

Is there anything that still needs to be done @yochananmarqos, at least for the source package?

yochananmarqos · 2023-02-13T19:57:24Z

Nope. I think we're fine for now. @FabioLolix took it upon himself to add the binary package as celeste-client-bin, so that might be confusing. Reason being celeste-bin already exists for the game. 🤷‍♂️

hwittenborn · 2023-02-13T20:03:06Z

That's fine for the binary package for now, it's not too big of a deal. At least for celeste do you think it's at a good state to add installation instructions to the README for it?

yochananmarqos · 2023-02-13T20:08:29Z

Well, Scott @ OMG!LINUX already posted about it, so you might as well update the README to let users know it's in the AUR.

PrzemekSkw · 2023-02-13T20:13:37Z

Sorry I don't mention You all who make thisAUR package. Thank You very much.

PrzemekSkw · 2023-02-13T20:23:34Z

I just build from AUR but have the sam issue as from flatpak. Cannot add remote folder.

yochananmarqos · 2023-02-13T20:34:07Z

@PrzemekSkw Please create a new issue if you need support.

PrzemekSkw · 2023-02-14T07:04:48Z

@PrzemekSkw Please create a new issue if you need support.

Hi, I already have the same issue with flatpak:
#24

hwittenborn · 2023-03-14T18:34:49Z

@yochananmarqos: I don't recall where we left off, but was there anything inhibiting adding the celeste AUR package as an installation option in the README?

yochananmarqos · 2023-03-14T18:48:23Z

@hwittenborn No, I think we're good.

hwittenborn · 2023-03-14T18:51:45Z

Cool, I'll get that added in a bit then - I'd like to add a note that it's community maintained by you just so everyone knows it's not maintained directly by me, is that fine with you?

yochananmarqos · 2023-03-14T18:56:22Z

S'okay, s'alright.

yochananmarqos · 2023-06-07T14:59:49Z

@hwittenborn This could probably be closed now, eh?

hwittenborn · 2023-06-07T15:12:06Z

Yeah I'll go ahead and do that @yochananmarqos. I completely forgot about adding AUR instructions into the README too, I'll go ahead and get that going in a few.

Is there any AUR helper I should list? I was thinking yay or paru but I don't really keep track of what AUR helpers are popular. I was thinking of listing makepkg instructions directly, but Celeste being able to update in a non-manual fashion is definitely something I'd prefer.

yochananmarqos · 2023-06-07T15:59:29Z

Both Yay and Paru are popular. I've been using Paru lately, myself. You could list both if you want. Something like this, maybe?

Arch Linux

Celeste is available in the AUR (Arch User Repository). Use your favorite AUR helper like Yay or Paru:

yay -S celeste

or

paru -S celeste

yochananmarqos · 2023-06-07T21:10:32Z

@hwittenborn Oops, forgot to tag you above. Doing it now just in case you aren't subscribed to closed issue notifications.

hwittenborn · 2023-06-07T21:16:56Z

Thanks for the heads up @yochananmarqos - I'm away from my computer right now, but I'll be back to get all that added in a few hours. I'll send a message here once I get it all added into the README too.

hwittenborn · 2023-06-08T07:35:10Z

@yochananmarqos: Are you fine if I put you as the maintainer of the package in the README? I was wanting to put them for anything that isn't an official installation method.

hwittenborn · 2023-06-08T07:41:42Z

See #112 for the new instructions I have right now.

yochananmarqos · 2023-06-08T14:04:14Z

@hwittenborn Yes, that's fine. The MR looks good.

yochananmarqos mentioned this issue Mar 14, 2023

Introduce support for GTK 4 AyatanaIndicators/libayatana-appindicator#22

Open

hwittenborn closed this as completed Jun 7, 2023

Add Archlinux support #25

Add Archlinux support #25

Comments

PrzemekSkw commented Feb 7, 2023

rhysperry111 commented Feb 8, 2023 • edited Loading

yochananmarqos commented Feb 8, 2023

hwittenborn commented Feb 8, 2023

rhysperry111 commented Feb 8, 2023 • edited Loading

hwittenborn commented Feb 8, 2023

yochananmarqos commented Feb 8, 2023 • edited Loading

rhysperry111 commented Feb 8, 2023

hwittenborn commented Feb 8, 2023

hwittenborn commented Feb 8, 2023

rhysperry111 commented Feb 8, 2023

yochananmarqos commented Feb 8, 2023

yochananmarqos commented Feb 8, 2023 • edited Loading

rhysperry111 commented Feb 8, 2023

yochananmarqos commented Feb 8, 2023

rhysperry111 commented Feb 8, 2023

hwittenborn commented Feb 8, 2023

hwittenborn commented Feb 8, 2023 • edited Loading

yochananmarqos commented Feb 8, 2023 • edited Loading

hwittenborn commented Feb 8, 2023

yochananmarqos commented Feb 8, 2023

hwittenborn commented Feb 8, 2023 • edited Loading

yochananmarqos commented Feb 9, 2023

rhysperry111 commented Feb 9, 2023

yochananmarqos commented Feb 9, 2023

rhysperry111 commented Feb 9, 2023

FabioLolix commented Feb 9, 2023

yochananmarqos commented Feb 9, 2023

FabioLolix commented Feb 9, 2023

yochananmarqos commented Feb 9, 2023

hwittenborn commented Feb 9, 2023

yochananmarqos commented Feb 9, 2023 • edited Loading

hwittenborn commented Feb 9, 2023

yochananmarqos commented Feb 9, 2023 • edited Loading

hwittenborn commented Feb 9, 2023

rhysperry111 commented Feb 9, 2023

hwittenborn commented Feb 13, 2023

yochananmarqos commented Feb 13, 2023

PrzemekSkw commented Feb 13, 2023

hwittenborn commented Feb 13, 2023

yochananmarqos commented Feb 13, 2023

hwittenborn commented Feb 13, 2023 • edited Loading

yochananmarqos commented Feb 13, 2023

PrzemekSkw commented Feb 13, 2023

PrzemekSkw commented Feb 13, 2023

yochananmarqos commented Feb 13, 2023

PrzemekSkw commented Feb 14, 2023

hwittenborn commented Mar 14, 2023

yochananmarqos commented Mar 14, 2023

hwittenborn commented Mar 14, 2023

yochananmarqos commented Mar 14, 2023

yochananmarqos commented Jun 7, 2023

hwittenborn commented Jun 7, 2023

yochananmarqos commented Jun 7, 2023

Arch Linux

yochananmarqos commented Jun 7, 2023 • edited Loading

hwittenborn commented Jun 7, 2023

hwittenborn commented Jun 8, 2023

hwittenborn commented Jun 8, 2023

yochananmarqos commented Jun 8, 2023

rhysperry111 commented Feb 8, 2023 •

edited

Loading

rhysperry111 commented Feb 8, 2023 •

edited

Loading

yochananmarqos commented Feb 8, 2023 •

edited

Loading

yochananmarqos commented Feb 8, 2023 •

edited

Loading

hwittenborn commented Feb 8, 2023 •

edited

Loading

yochananmarqos commented Feb 8, 2023 •

edited

Loading

hwittenborn commented Feb 8, 2023 •

edited

Loading

yochananmarqos commented Feb 9, 2023 •

edited

Loading

yochananmarqos commented Feb 9, 2023 •

edited

Loading

hwittenborn commented Feb 13, 2023 •

edited

Loading

yochananmarqos commented Jun 7, 2023 •

edited

Loading