-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcoded properties #27
Comments
You can override both the
I have no experience with fly.io, not sure if it is possible to do this via their platform. As for the proposals - I believe it might break existing setups, don't really want to do that. |
You don't run docker command when deploy to fly.io, so unfortunately that's not an option. I think you can fix that so it will work for old users. Just add .filebrowser.yaml
And copy it in Dockerfile
The priority listed here https://filebrowser.org/cli/filebrowser will let us override properties easily with ENVs or replace .filebrowser.yaml in simple Dockerfile not recreating whole workflow just to set own variables. Flags have highest priority that makes your image braking original customisation. So, that was my suggestion how to fix that. |
Just an example of my props. I've also added Nginx to the image to use another subpath.
As I mentioned, this config lets me mount one single volume. |
The next command in Dockerfile makes impossible to re-map the folders structure
CMD ["--root=/data", "--address=0.0.0.0", "--database=/config/filebrowser.db"]
Example of real life issue: I've tried to deploy this to fly.io, but it allows to mount only 1 volume.
I've solved this issue by removing this command and slightly modifying your Dockerfile + starting from custom .sh entrypoint to have ability to make some initial preparations.
Proposal:
That's what I've actually did
In my case my folders structure is
root: /data/data
database: /data/config/filebrowser.db
So I can mount single /data directory.
In .sh script I create /data/data directory so FileBrowser can find it.
The text was updated successfully, but these errors were encountered: