Dialog does not return focus to triggering element

[myieye]

Describe the bug

The docs say:

When a Dialog closes, focus returns to the element that triggered its opening (typically the Dialog.Trigger).

I only see that happening if I either:

1. Use <Dialog.Trigger> to open the dialog
2. Close a nested dialog

I understand the docs to mean that it should also happen even if I use a simple <button> to set open to true.
But if I do that, then focus is returned to the body when the dialog is closed.

Reproduction

myieye@99acc00

System Info

System:
    OS: Windows 11 10.0.26100
    CPU: (16) x64 AMD Ryzen 7 5825U with Radeon Graphics
    Memory: 4.94 GB / 22.83 GB
  Binaries:
    Node: 20.18.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.8.2 - C:\Program Files\nodejs\npm.CMD
    pnpm: 10.12.1 - C:\Program Files\nodejs\pnpm.CMD
  Browsers:
    Edge: Chromium (139.0.3405.86)
    Internet Explorer: 11.0.26100.1882
  npmPackages:
    svelte: catalog: => 5.33.2

Severity

annoyance

[huntabyte]

This is a tough one because there doesn't necessarily have to be a triggering element. It could be opened as a side effect of something else.

[myieye]

Yeah, that's true, but it seems reasonable to (as a default) try to restore focus to whatever had focus before the dialog took focus. Even if it didn't trigger the dialog. That seems to happen automatically if I open a nested dialog.

[huntabyte]

Completely agree, will look into this when I have some cycles. Will need to ensure it works well with overrides via onCloseAutoFocus etc.

[myieye]

Could it simply be the default value/implementation of onCloseAutoFocus? That's how I "patched" this in our code sillsdev/languageforge-lexbox@e521270#diff-a0daeb2ee76f2aa987a6d18b28020718a4d544f2eca421c7489d5e971d18d2e1R86.