-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding wizard feedback #578
Comments
If you run the
Fair point
Yes this could be cleaned up
👍
👍
The two addresses being printed out are different addresses. When I say open localhost:8080 that is the address your web client should open as that is where the server is running. The address being printed out when you run the server is the address the server is listening on. Because you are running both client and server on the same machine they happen to be the same. But the server could also be listening on 0.0.0.0:8080, which indicates it will accept clients from any address.
Using a host name for your listen address has performance impacts and should not be encouraged.
Thank you for taking your time to put your thoughts down. Hopefully we can get this right over time. |
1: You're right, looking through my shell history I aborted the first configure and then tried again by adding the package name but can't remember why. 😅 6: I think at least formatting the address as 7: That makes sense. In my head I was comparing against Ktor which outputs:
No problem! If you turn any of these suggestions into Issues I'm happy to take a stab at some of them while I play around with this some more. |
|
Hey, been following along and am excited for this project. I gave it a spin on and had some feedback for the onboarding/new project process, figured it made sense to group it all here.
Enter your package name:
package name is such an overloaded term I thought it was asking for a bundle ID. Maybe it could be phrased as "Swift Package name" to be unambiguous.~/dev/hummingbird-template
a few times.Enter the folder created and run 'swift run' to build and run your server.
coupled with my confusion earlier about how this creates a sub-directory with the scaffolded project, I was thinking "what folder"? Could it explicitly tell me which folder to open?Then open 'localhost:8080' on your web browser.
I don't think the CLI needs to say this sinceswift run
already outputs this too.swift run
it actually outputs[HummingbirdCore] Server started and listening on 127.0.0.1:8080
, it would be nice if it saidlocalhost:8080
for consistency. VSCode also seems to stumble trying to CMD+click opening127.0.0.1:8080
into the browser so it would probably work better with localhost like other frameworks use.Other than that everything worked! Excited to follow along.
The text was updated successfully, but these errors were encountered: