Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This application is vulnerable #25

Open
ChiChou opened this issue Jan 9, 2018 · 1 comment
Open

This application is vulnerable #25

ChiChou opened this issue Jan 9, 2018 · 1 comment
Labels
bug

Comments

@ChiChou
Copy link

ChiChou commented Jan 9, 2018

There's a easy exploiting vulnerability in:
https://github.com/humitos/pyfispot/blob/master/raspberrypi/home/pi/apps/pyfispot/main.py#L69

A fake X-Real-IP header will execute arbitrary command on the server
@humitos
Copy link
Owner

humitos commented Jan 9, 2018

Thanks for your report. You are right.

We will need to validate that the request.remote_addr is a valid IP. Maybe with a regex? Would you like to propose a PR for this?

@humitos humitos added the bug label Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humitos @ChiChou