Add support for customToken #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tuan Anh Nguyen <[email protected]>
|
@SaaldjorMike @jespermbyskov anyone can have a quick look please? |
fjerlov-cs
reviewed
Sep 30, 2024
| @@ -76,25 +76,30 @@ func toIngestToken(data ingestTokenData) *IngestToken { | |||
| } | |||
| } | |||
|
|
|||
| func (i *IngestTokens) Add(repositoryName string, tokenName string, parser string) (*IngestToken, error) { | |||
| func (i *IngestTokens) Add(repositoryName string, tokenName string, parser string, customToken string) (*IngestToken, error) { | |||
There was a problem hiding this comment.
This would be a breaking change for Go API users.
Could we rename it to AddV2 and call it from ingest_tokens_add.go and Add() to keep the signature? @SaaldjorMike
func (i *IngestTokens) Add(repositoryName string, tokenName string, parser string) (*IngestToken, error) {
return i.AddV2(repositoryName, tokenName, parser, "")
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157