Merge pull request #88 from humhub/fix/45-save-button-visibility

Hide the save button when user has no permission to manage translations

Author: luke-

docs/CHANGELOG.md

@@ -22,6 +22,7 @@ Changelog
 - Enh #82: Migration to Bootstrap 5 for HumHub 1.18
 - Enh #83: Improved Module Test GitHub Actions
 - Enh #84: Implemented `module-coding-standards`
+- Fix #88: Hide the save button when user has no permission to manage translations
 
 1.0.0 (June 10, 2020)
 -----------------------

models/forms/TranslationForm.php

@@ -216,7 +216,7 @@ protected function loadMessages()
     protected function autoTranslateEmptyValues(int $queryStart = 1)
     {
         // Get target language code
-        $targetLanguageCode = strtr($this->language, static::HUMHUB_LANGUAGE_CODE_TO_GOOGLE_TRANSLATE);
+        $targetLanguageCode = strtr((string)$this->language, static::HUMHUB_LANGUAGE_CODE_TO_GOOGLE_TRANSLATE);
 
         // Check if code is supported by Google translate
         if (!in_array($targetLanguageCode, static::GOOGLE_TRANSLATE_SUPPORTED_LANGUAGES)) {
@@ -294,13 +294,19 @@ protected function autoTranslateEmptyValues(int $queryStart = 1)
         }
     }
 
+    public function canManage(): bool
+    {
+        return $this->space instanceof Space
+            && $this->space->can(ManageTranslations::class);
+    }
+
     /**
      * @return bool
      * @throws \yii\base\Exception
      */
     public function save()
     {
-        if (!$this->space || !$this->space->can(ManageTranslations::class)) {
+        if (!$this->canManage()) {
             return false;
         }
 

widgets/views/translationForm.php

@@ -15,21 +15,22 @@
 
 $errors = null;
 
-if($model->hasErrors()) {
+if ($model->hasErrors()) {
     $errors = Html::errorSummary($model, [
-        'header' => '<strong>'.Yii::t('TranslationModule.base', 'The translations for {settings} could not be loaded:', $model->getMessageSettingString()).'</strong>',
+        'header' => '<strong>' . Yii::t('TranslationModule.base', 'The translations for {settings} could not be loaded:', $model->getMessageSettingString()) . '</strong>',
     ]);
 
     // Fallback to default selection
     $model = new TranslationForm();
     $model->load([]);
 
-    if(!$model->validate()) {
+    if (!$model->validate()) {
         throw new NotFoundHttpException();
     }
 }
 
 $hasParentLanguage = $model->getParentLanguage() !== null;
+$canManage = $model->canManage();
 ?>
 
 <?= Html::beginTag('div', $options) ?>
@@ -72,7 +73,7 @@
 
         <div class="panel-body">
 
-            <?php if(!empty($errors)) : ?>
+            <?php if (!empty($errors)) : ?>
 
                 <div class="alert alert-danger">
                     <?= $errors ?>
@@ -95,7 +96,7 @@
                 </div>
 
                 <p class="clearfix" style="margin-bottom:0">
-                    <?= Button::save()->submit()->right() ?>
+                    <?= $canManage ? Button::save()->submit()->right() : '' ?>
                 </p>
 
                 <hr class="mt-0">
@@ -111,21 +112,27 @@
                             <div class="elem">
                                 <div class="pre"><?= Html::encode($original) ?></div>
                                 <div>
-                                    <?= Button::light('<span>' . Yii::t('TranslationModule.base', 'Adopt original language') . '</span>')
+                                    <?= $canManage
+                                        ? Button::light('<span>' . Yii::t('TranslationModule.base', 'Adopt original language') . '</span>')
                                         ->icon('arrow-right')
                                         ->action('copyOriginal')
                                         ->tooltip(Yii::t('TranslationModule.base', 'Adopt original language'))
-                                        ->loader(false) ?>
+                                        ->loader(false)
+                                        : '' ?>
                                 </div>
                             </div>
                             <div class="elem <?= $model->getTranslationFieldClass($original) ?>">
                                 <div>
-                                    <?= Html::textArea(TranslationLog::tid($original), $translated, [
-                                        'class' => 'form-control translation ' . (empty($translated) ? 'empty' : 'translated'),
-                                        'placeholder' => $model->parentMessages[$original] ?? '',
-                                    ]) ?>
+                                    <?php if ($canManage) : ?>
+                                        <?= Html::textArea(TranslationLog::tid($original), $translated, [
+                                            'class' => 'form-control translation ' . (empty($translated) ? 'empty' : 'translated'),
+                                            'placeholder' => $model->parentMessages[$original] ?? '',
+                                        ]) ?>
+                                    <?php else : ?>
+                                        <div class="pre"><?= Html::encode($translated) ?></div>
+                                    <?php endif; ?>
 
-                                    <?php if(!empty($model->getHelpBlockMessage($original))) : ?>
+                                    <?php if (!empty($model->getHelpBlockMessage($original))) : ?>
                                         <p class="form-text"><?= Html::encode($model->getHelpBlockMessage($original)) ?></p>
                                     <?php endif; ?>
                                 </div>
@@ -136,13 +143,14 @@
                                     ->tooltip(Yii::t('TranslationModule.base', 'View translation history'))
                                     ->loader(false) ?>
 
-                                <?= $hasParentLanguage ?
-                                    Button::success('<span>' . Yii::t('TranslationModule.base', 'Confirm translation') . '</span>')
+                                <?= $hasParentLanguage && $canManage
+                                    ? Button::success('<span>' . Yii::t('TranslationModule.base', 'Confirm translation') . '</span>')
                                     ->icon('check')
                                     ->action('copyParent')
                                     ->tooltip(Yii::t('TranslationModule.base', 'Confirm translation'))
                                     ->cssClass($translated === '' ? '' : 'translation-confirm-approved')
-                                    ->loader(false) : '' ?>
+                                    ->loader(false)
+                                    : '' ?>
                                 </div>
                             </div>
                         </div>
@@ -152,7 +160,7 @@
                 <hr>
 
                 <p class="clearfix">
-                    <?= Button::save()->submit()->right() ?>
+                    <?= $canManage ? Button::save()->submit()->right() : '' ?>
                 </p>
             <?php endif; ?>
         </div>