Message reaction

[buddh4]

Message reactions as like/emojis

[Semir1212]

A small selection like this one (or just a thumbs up) would be useful:

[marc-farre]

@Semir1212 maybe I could have a try to add the like module, which allows using the https://marketplace.humhub.com/module/reaction/description module.

[Semir1212]

@marc-farre That sounds like a good idea, even if I think it should ultimately be part of the Messenger module itself.

[marc-farre]

@Semir1212 Maybe we could later merge the Reaction module into HumHub core.

I'll try to work on this issue as soon as possible.

[latamclick]

Hello, reactions (https://marketplace.humhub.com/module/reaction/description) work for HumHub Messenger module?

[marc-farre]

@luke- PR #388 adds "Like" to message entries.

I had to make AbstractMessageEntry extends ContentActiveRecord instead of ActiveRecord.

And because of that, I had to rename the content column to entry_content in the message_entry table.
Let me know if you have a better idea for entry_content. I think it should be called message (as for Post and Comment), but it would be confusing with the message parent table.

@Semir1212 @latamclick Once this new version of the Mail module will be released, I'll release a new version of the Reaction module to work with it.

[marc-farre]

Commit 99eff04 also fixes this issue (founded by automatic tests):
Notification not sent to the participant added to the conversion

By fixing this issue, I've discovered another one: #389

[luke-]

@marc-farre Hmm, Messages from Mail module should not actually be derived from the “ContentActiveRecord”. I'm not sure how best to proceed here.

We will probably have to modify the Like module so that it does support non-content as well.

[marc-farre]

@luke-

• PR to allow Like on non-content: Enh: Allow "Like" on non-content objects humhub#7002
• PR for the Messenger module: Enh #188: Add "Like" to message entries #391

I have created the LikeNotificationInterface interface.
And I had to extend the Like model from ActiveRecord instead of ContentAddonActiveRecord.

Test:

Result:

There is an issue with emojis, but I don't think it's related to these PRs. I'll do more tests later about it.

Let me know what you think about it. I haven't done a lot of tests at the moment. I would first want to know if I'm going the right direction.

Codeception tests on the Messenger module cannot work without first merging the PR for the core.

[latamclick]

@marc-farre #188 (comment)
This module is already available for download?

[marc-farre]

This module is already available for download?

@latamclick No, it's under development, but unfinished.
It will be available when this issue is closed and the new versions of HumHub and Messenger module are released.
It might take time.

[ilMagnifico]

Bumping this too.

[marc-farre]

@luke- I have merged:

• Core develop into PR to allow Like on non-content: Enh: Allow "Like" on non-content objects humhub#7002
• Messenger master into PR for the Messenger module: Enh #188: Add "Like" to message entries #391

For the Messenger module, I added v3.2.4 to the changelog because it's compatible with 1.17 only, whereas the upcoming 3.2.3 is still compatible with 1.16.

Tests are OK on HH core, but of course fail for Messenger, as tests are done with HH master which doesn't yet have the LikeNotificationInterface.

Can I do anything else to progress on this topic? Thanks!

[luke-]

@marc-farre Thank you for keeping the PR up to date.

I'm not that happy with the implementation and I have to think about how we could better deal with content add-ons and such situations.

Please give me a bit time here. Currently there are other tasks.

[lashab82]

Hi Luke, any progress on this one? It's a feature that we would really appreciate to have in the Messenger module.