Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links are not styled in Rich text fields #372

Open
Gilbertdelyon opened this issue Jan 9, 2025 · 8 comments
Open

Links are not styled in Rich text fields #372

Gilbertdelyon opened this issue Jan 9, 2025 · 8 comments

Comments

@Gilbertdelyon
Copy link

Gilbertdelyon commented Jan 9, 2025

HH1.16.2 - Native theme
Rich text field in a custm page

Links are styled in editor (TinyMCE) input.
But they are not in the page.

I get this when I inspect the link in the page

body a, body a:hover, body a:focus, body a:active, body a.active {
    color: #000;
    text-decoration: none;
@Gilbertdelyon Gilbertdelyon changed the title Links are not styled in TinyMCE Links are not styled in Rich text fields Jan 9, 2025
@yurabakhtin
Copy link
Contributor

@luke- I see the link color is used since this commit, so I am not sure how to change that.
The color text-color-highlight was updated from #555 to #000 here.

edit-richtext

view-link

@luke-
Copy link
Contributor

luke- commented Jan 14, 2025

@yurabakhtin It would be good if TinyMCE also used the default link color. Similar to the ProseMirror editor. Do you see a problem to change that?

@yurabakhtin
Copy link
Contributor

@luke- Ok, done in the PR #373:

cp-body-style

@yurabakhtin yurabakhtin linked a pull request Jan 14, 2025 that will close this issue
@luke-
Copy link
Contributor

luke- commented Jan 14, 2025

Hmm, why black? I had expected the same color like here:

image

@yurabakhtin
Copy link
Contributor

@luke- Because the element "HumHub RichText" is on your screenshot, the style [data-ui-richtext] a { blue color } is used from here.

But the element "RichText" is not rendered as richtext/markdown, the html is built by TinyMce editor, the style body a { black color} is used from here.

Maybe we should use the same blue color for all links in body?

colors

@luke-
Copy link
Contributor

luke- commented Jan 14, 2025

@yurabakhtin Thanks for the info.

@marc-farre What do you think? Probably we should change the stylesheet behavior here? I would prefer the BS5 branch for that.

@marc-farre
Copy link
Contributor

@luke- @yurabakhtin I really don't know if we should define the "Link" color at the body level (body a).
But I agree, now that 1.17 stable is released, it would be better to make changes on bs5 branch directly.
Once you have decided where to apply this color, if you want, I can take care of the change in the bs5 branch, using the CSS var(--bs-link-color).

@luke-
Copy link
Contributor

luke- commented Jan 14, 2025

@marc-farre That would be great. I've created an issue for it here: https://github.com/humhub/humhub-internal/issues/519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants