Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional menu bar when opening from notification #264

Open
felixhahnweilheim opened this issue Dec 20, 2024 · 21 comments
Open

additional menu bar when opening from notification #264

felixhahnweilheim opened this issue Dec 20, 2024 · 21 comments
Assignees
Labels
bug Something isn't working

Comments

@felixhahnweilheim
Copy link

I keep finding bugs:
I got a new content notification from community.humhub.com and opened it. It correctly opens the app but with an additional menu bar
Screenshot_20241220_191255

The options were "Go back", "Go forward", "Share", "Close"

Share seems to work
Close only leaves a blank page
I didn't try the others

But all in all I think this menu bar should not sppear at all. (although the share option would be good to have in general)

@marc-farre marc-farre added the bug Something isn't working label Dec 21, 2024
@marc-farre
Copy link
Collaborator

@felixhahnweilheim Thanks.
@mbumpalumpa It also happens I have this issue.
As we have removed this menu for SSO login, could we find a solution to always remove it in all cases, even when the URL doesn't match in manifest.json?

@mbumpalumpa
Copy link

@marc-farre so, the issue occurs when the user clicks on the push notification, right? And we're talking about the kebab menu icon, correct? Additionally, I think Primož is the go-to person here, or are you asking for a solution design-wise?

Also, I would like to add that I do not own an Android phone, so I'm unable to test this. The only app I have for iOS is the flavored one, Omrade. 😬

397828971-3b40c76c-f70e-41d4-adce-3ddb51a73896

@marc-farre
Copy link
Collaborator

marc-farre commented Dec 23, 2024

@mbumpalumpa

the issue occurs when the user clicks on the push notification, right?

It's not easy to reproduce on my side, so not all the time.

we're talking about the kebab menu icon, correct?

yes, the part you highlighted on the screenshot.

are you asking for a solution design-wise?

@PrimozRatej will answer better for the available solutions, but I was thinking about a way to remove this menu in all cases, not depending on some conditions.

@mbumpalumpa
Copy link

Regarding that menu, yes, I would also remove it if it is useless (I don't know if we use it in some scenario for something?), as it just takes up screen real estate to add a few options, some of which don't even work.

@PrimozRatej
Copy link
Collaborator

PrimozRatej commented Dec 23, 2024

This shouldn't happen; it is a bug. This bar is added only on the SSO auth redirect (so the user can close the SSO popup) and should not be added to the actual instance. However, I can't seem to replicate the error. I also tested it with LinkedIn SSO login; the redirect to the end instance does not show this extra header navigation bar.

My demo instance (Logged in with SSO + opened from push):
image

Felix development instance (pass/username login):
image

@felixhahnweilheim could you please share how did you came to this state, does this only happen when opening from push notification?

@felixhahnweilheim
Copy link
Author

It only happens with push notification and so far only with the HumHub community

@felixhahnweilheim
Copy link
Author

And I am logged in normally with username and password, no SSO

@felixhahnweilheim
Copy link
Author

Today I got 2 notifications from the HumHub community and it didn't happen anymore. So from my side this issue could be closed.

@marc-farre
Copy link
Collaborator

@felixhahnweilheim Thanks for your feedback.
We should keep this issue opened, because I also experiment it randomly, though quite rarely.

@felixhahnweilheim
Copy link
Author

The issue occured again (with HumHub Community).
I also got a new state with title "HumHub", the mentioned options and a search icon (see screenshot).
The search icon opened a search box but of course it didn't work.

The page stayed blank (could also be due to weak internet connection in my case).

Screenshot_20250103_204823.jpg

@felixhahnweilheim
Copy link
Author

In the HumHub Community, the "Switch Network" button also disappeared, so maybe this is connected?

Actually I would say the app should block instances that don't have the "Switch Network" option. It would make sure users never get stuck (and maybe even have to empty the app cache manually).
Of course, users can also log out but often you just want to switch.

Maybe there should even be a mechanism when a HumHub instance is stuck (e.g. custom JS that has errors), after a while the app goes back to the start screen (with a failure notice) or asks the user how to proceed.

I'm just sharing a few thoughts, I did not dig into the code what's already done and what would be possible.

@marc-farre marc-farre assigned PrimozRatej and unassigned mbumpalumpa Jan 9, 2025
@PrimozRatej
Copy link
Collaborator

Hey @felixhahnweilheim, thank you for describing the findings from your side. A quick follow-up: did this bug appear again for you in the meantime? While testing and working on the app, I couldn't replicate this bug with any physical or virtual device.
I would be grateful if you could share the specifications of your device, specifically the API level and model. Thank you.

@felixhahnweilheim
Copy link
Author

Hi, I just updated the app 2 days ago and didn't experience it so far. Maybe you could send me a PM in the Community so I get a push notification or I just wait for the next one.

Model: SM-A515F/DSN
Android 13
Is that what you need?

@PrimozRatej
Copy link
Collaborator

Tnx for info, just send you a test msg.

@felixhahnweilheim
Copy link
Author

Thanks for the messages. The bug seems to be solved.

@PrimozRatej
Copy link
Collaborator

I'm afraid it's not. @marc-farre found it again a couple of days back. What is strange is the randomness of it - it happens only in some particular cases that we haven't found out yet. I will keep you posted. Thanks for all the provided info.

@felixhahnweilheim
Copy link
Author

Yes it happened again.
My experience:

  • New content notification: additional top bar appears
  • New message/conversation (mail module): everything works fine

Maybe it's connected to the notification category, just a thought...

And so far I didn't have it with own instances, only HumHub Community.

@felixhahnweilheim
Copy link
Author

Screen_Recording_20250124_172636.mp4

New Behaviour:
Switch Network opens the additional top bar. Close removes it again.
So I can't switch.

@marc-farre
Copy link
Collaborator

@felixhahnweilheim Thanks for your feedback. We have implemented a new debugger to allow us having the log of everything that happened in case of such a bug.
If you have the latest version of the Push Notification module, and the latest 1.1.5 version of the mobile app, you can find it here:

Image

Image

Image

Of course, you cannot do it with the https://community.humhub.com/ instance, but if you have the issue, even on it, and you manage to switch to your instance, please share the log you have here.

But hopefully I'll manage to reproduce it on my side again!
Thanks for your help!

@felixhahnweilheim
Copy link
Author

I think the question is why sometimes the HumHub Community does not show the "Switch Network" button. Maybe a problem with the app detection?
Is it running the last official version of the FCM module or another git branch?
Maybe this would help reproducing the error on an own instance.

@marc-farre
Copy link
Collaborator

@felixhahnweilheim you need v2.1.2 or later.

But when you see the additional menu bar, of course, this is a bug, so the app is not detected, and the "Switch Network" is not displayed (HumHub think it's browsed by a normal web browser).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants