-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional menu bar when opening from notification #264
Comments
@felixhahnweilheim Thanks. |
@marc-farre so, the issue occurs when the user clicks on the push notification, right? And we're talking about the kebab menu icon, correct? Additionally, I think Primož is the go-to person here, or are you asking for a solution design-wise? Also, I would like to add that I do not own an Android phone, so I'm unable to test this. The only app I have for iOS is the flavored one, Omrade. 😬 |
It's not easy to reproduce on my side, so not all the time.
yes, the part you highlighted on the screenshot.
@PrimozRatej will answer better for the available solutions, but I was thinking about a way to remove this menu in all cases, not depending on some conditions. |
Regarding that menu, yes, I would also remove it if it is useless (I don't know if we use it in some scenario for something?), as it just takes up screen real estate to add a few options, some of which don't even work. |
This shouldn't happen; it is a bug. This bar is added only on the SSO auth redirect (so the user can close the SSO popup) and should not be added to the actual instance. However, I can't seem to replicate the error. I also tested it with LinkedIn SSO login; the redirect to the end instance does not show this extra header navigation bar. My demo instance (Logged in with SSO + opened from push): Felix development instance (pass/username login): @felixhahnweilheim could you please share how did you came to this state, does this only happen when opening from push notification? |
It only happens with push notification and so far only with the HumHub community |
And I am logged in normally with username and password, no SSO |
Today I got 2 notifications from the HumHub community and it didn't happen anymore. So from my side this issue could be closed. |
@felixhahnweilheim Thanks for your feedback. |
In the HumHub Community, the "Switch Network" button also disappeared, so maybe this is connected? Actually I would say the app should block instances that don't have the "Switch Network" option. It would make sure users never get stuck (and maybe even have to empty the app cache manually). Maybe there should even be a mechanism when a HumHub instance is stuck (e.g. custom JS that has errors), after a while the app goes back to the start screen (with a failure notice) or asks the user how to proceed. I'm just sharing a few thoughts, I did not dig into the code what's already done and what would be possible. |
Hey @felixhahnweilheim, thank you for describing the findings from your side. A quick follow-up: did this bug appear again for you in the meantime? While testing and working on the app, I couldn't replicate this bug with any physical or virtual device. |
Hi, I just updated the app 2 days ago and didn't experience it so far. Maybe you could send me a PM in the Community so I get a push notification or I just wait for the next one. Model: SM-A515F/DSN |
Tnx for info, just send you a test msg. |
Thanks for the messages. The bug seems to be solved. |
I'm afraid it's not. @marc-farre found it again a couple of days back. What is strange is the randomness of it - it happens only in some particular cases that we haven't found out yet. I will keep you posted. Thanks for all the provided info. |
Yes it happened again.
Maybe it's connected to the notification category, just a thought... And so far I didn't have it with own instances, only HumHub Community. |
Screen_Recording_20250124_172636.mp4New Behaviour: |
@felixhahnweilheim Thanks for your feedback. We have implemented a new debugger to allow us having the log of everything that happened in case of such a bug. Of course, you cannot do it with the https://community.humhub.com/ instance, but if you have the issue, even on it, and you manage to switch to your instance, please share the log you have here. But hopefully I'll manage to reproduce it on my side again! |
I think the question is why sometimes the HumHub Community does not show the "Switch Network" button. Maybe a problem with the app detection? |
@felixhahnweilheim you need v2.1.2 or later. But when you see the additional menu bar, of course, this is a bug, so the app is not detected, and the "Switch Network" is not displayed (HumHub think it's browsed by a normal web browser). |
I keep finding bugs:
I got a new content notification from community.humhub.com and opened it. It correctly opens the app but with an additional menu bar
The options were "Go back", "Go forward", "Share", "Close"
Share seems to work
Close only leaves a blank page
I didn't try the others
But all in all I think this menu bar should not sppear at all. (although the share option would be good to have in general)
The text was updated successfully, but these errors were encountered: