Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 proposal] Improved defaults for quantization and device selection #960

Open
xenova opened this issue Oct 4, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@xenova
Copy link
Collaborator

xenova commented Oct 4, 2024

Feature request

Currently, Transformers.js V3 defaults to use CPU (WASM) instead of GPU (WebGPU) due to lack of support and instability across browsers (specifically Firefox and Safari, and Chrome in Ubuntu). However, this provides a poor user experience since is performance left on the table. As browser support for WebGPU increases (currently ~70%), this will become more important since users may experience poor performance when better settings are available.

A better proposal should be to use device: "auto" instead of device: null by default, which should select (1) quantization and (2) device) based on the following:

  1. Browser support (e.g., whether WebGPU is enabled)
  2. Device capabilities (OS, mobile vs. desktop, fp16 support)
  3. Model architecture/type (BERT models are more likely to succeed than encoder-decoder models) - some models have ops which are not supported in WebGPU.

Motivation

Improve user experience and performance with better defaults

Your contribution

Will work with @FL33TW00D on this

@xenova xenova added the enhancement New feature or request label Oct 4, 2024
@FL33TW00D
Copy link

auto_device

@xenova
Copy link
Collaborator Author

xenova commented Oct 4, 2024

Current logic for session selection: https://github.com/xenova/transformers.js/blob/6505abb164a3eea1dd5e80e56a72f7d805715f0a/src/models.js#L148-L262

Request / commit for ability to set adapter in ORT-web

@FL33TW00D
Copy link

FL33TW00D commented Oct 17, 2024

Some thoughts:

  • Most users of Transformers.JS will want the optimal device to be selected for them, using Device.AUTO.
  • Some advanced users will want to force an ExecutionProvider to be used.
  • We need to support both of the above use cases.

Currently, the distinction between our DEVICE_TYPES and ORT is quite blurry.

I propose:

  • Create a class Device which is a Transformers.JS Device.
  • Simplify DEVICE_TYPES to just handle Auto, CPU, GPU, and NPU.
  • Use conversion functions to convert from Device -> ORTBackend etc.

This class will encapsulate all of the logic wrt to devices and converting a Device into the required ExecutionProvider when it is required. This device will also implement the above flow chart to ensure that users get the best experience.

The class Device will primarily expose CPU, GPU, and NPU, but users will also be able to directly provide an ORTExecutionProvider to skip our whole flowchart and force their required EP.

We should create a class Device and keep the enum DEVICE_TYPES here. The enum should be changed to ensure no bleeding between us and ORT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants