Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test ORTModel.from_pretrained() for all architectures #664

Closed
fxmarty opened this issue Jan 3, 2023 · 2 comments · Fixed by #675
Closed

Test ORTModel.from_pretrained() for all architectures #664

fxmarty opened this issue Jan 3, 2023 · 2 comments · Fixed by #675
Labels
onnxruntime Related to ONNX Runtime

Comments

@fxmarty
Copy link
Contributor

fxmarty commented Jan 3, 2023 •
edited
Loading

Feature request

Test against all architectures in tests/onnxruntime/test_modeling.py.

Motivation

Sometimes we have issues reported that ORTModel.from_pretrained(from_transformers=True) fails. It's a sign our tests are too weak, notably the MODEL_NAMES and SUPPORTED_ARCHITECTURES in tests/onnxruntime/test_modeling.py.

For example: #555 (comment)

Your contribution

/
@fxmarty fxmarty added the onnxruntime Related to ONNX Runtime label Jan 3, 2023
@bhavnicksm
Copy link

Created an independent issue based on the problem I was facing in comment #555 --> #665

@fxmarty
Copy link
Contributor Author

fxmarty commented Jan 4, 2023

Same issue #669

@fxmarty fxmarty mentioned this issue Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
onnxruntime Related to ONNX Runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test more architectures in ORTModel fxmarty/optimum
2 participants
@fxmarty @bhavnicksm