Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it ok to write the target_modules in full? #752

Open
jackswl opened this issue Sep 3, 2024 · 1 comment
Open

Is it ok to write the target_modules in full? #752

jackswl opened this issue Sep 3, 2024 · 1 comment
Labels

Comments

@jackswl
Copy link

jackswl commented Sep 3, 2024

The configs gave

target_modules: all-linear

Is this equivalent to the code below?

target_modules: "q_proj,v_proj,o_proj,k_proj,gate_proj,down_proj,up_proj"

Will there be any differences between the either option? Is that the correct format for the second code? This is for SFT LLM. Thanks. @abhishekkrthakur

Copy link

github-actions bot commented Oct 3, 2024

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant