Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include ERC72.huff got duplicate macro name #141

Open
boying52 opened this issue Jun 4, 2024 · 1 comment
Open

include ERC72.huff got duplicate macro name #141

boying52 opened this issue Jun 4, 2024 · 1 comment

Comments

@boying52
Copy link

boying52 commented Jun 4, 2024

I got the error of compiling that it told me I have duplicate macro function, when I am writing the huffs with using huffmate, I think the reason is ERC721 included two files that are CommonErros.huff and nonpayable.huff, they all imported the same file that is Errors.huff. My #include visions are following:

MyTest.Huff ---> #include ECR721.huff

or

MyTest.Huff ----> #include hashmap.huff & #include ECR721.huff

above situations can cause the errors that including of duplicate to happen.

@MathisGD
Copy link
Collaborator

MathisGD commented Jun 6, 2024

I believe that this is linked to the change in huffc which raises an error when there are duplicate macros in a compiled file (including imports), while in the past it was possible to do this (it was taking one of the two, probably the first one chonologically). This is what makes tests fail btw (#138). If I have some spare time in the coming days, I will try to fix this because it's ruining the experience with this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants