Upgrade minimum Python version to 3.8 #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a changelog entry. |
Gamenot
reviewed
Mar 10, 2023
| sudo apt-get install $1 software-properties-common | ||
| sudo add-apt-repository $1 ppa:deadsnakes/ppa | ||
| sudo apt-get install $1 python3.7 python3.7-tk python3.7-venv | ||
| sudo apt-get install $1 python3.8 python3.8-tk python3.8-venv |
There was a problem hiding this comment.
Do you know why we need python Tkinter? It is not in most other requirements.
There was a problem hiding this comment.
I'm not sure. It seems it's been there for a while.
Gamenot
approved these changes
Mar 10, 2023
Adaickalavan
approved these changes
Mar 10, 2023
|
Eventually, we will be upgrading |
|
Is there anything blocking this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the minimum supported Python version to 3.8. This has been planned for some time, but was made necessary during the Argoverse 2 integration which requires >=3.8.
Some package version changes were needed:
ray[rllib]from1.0.1.post1to1.4.0to get rid ofgym[atari]dependency which had problems installing in 3.8numpy<1.24.0upper bound to fix an issue withray[rllib]==1.4.0(see [Datasets] numpy 1.24 breaks np.int, np.long which are used in tests ray-project/ray#31258)Note also that an issue with notebooks popped up: #1902. We have decided to ignore the test for now to unblock the Argoverse integration, but this should be investigated.