Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Remove wait_to_hijack_limit_s from EntryTactic to prevent unexpected issues #2050

Open
qianyi-sun opened this issue May 31, 2023 · 0 comments
Open

[Feature request] Remove wait_to_hijack_limit_s from EntryTactic to prevent unexpected issues #2050

qianyi-sun opened this issue May 31, 2023 · 0 comments
Assignees
@Gamenot
Labels
enhancement New feature or request

Comments

@qianyi-sun
Copy link
Contributor

qianyi-sun commented May 31, 2023 •
edited by Gamenot
Loading

Motivation

The wait_to_hijack_limit_s has become redundant with the condition field of the TrapEntryTactic.

Proposal

Supply the start time condition through condition. This should allow for the choice between waiting a number of steps or waiting until a given simulation time.

Alternatives

None

Additional context

This is a follow-up to #1965 which attempts to implement logical (and temporal) conditions that describe how to select vehicles from scenario studio.
@qianyi-sun qianyi-sun added the enhancement New feature or request label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gamenot Gamenot

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gamenot @qianyi-sun