Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Clarify relation between position and dynamics observations #1990

Open
2 tasks
Gamenot opened this issue Apr 27, 2023 · 0 comments
Open
2 tasks
Labels
enhancement New feature or request

Comments

@Gamenot
Copy link
Collaborator

Gamenot commented Apr 27, 2023

Motivation

The request is to clarify the meaning of the dynamics observations.

It is not currently clear what the relationship is between the global Cartesian coordinate position of the vehicle and the relative values that the dynamics observations provide. The current observations are as follows:

observation
|- ego_vehicle_observation
||- position: vec2 (global)
||- heading: float (global)
||- linear_velocity: vec2 (vehicle relative)
||- angular_velocity: vec2 (vehicle relative)
||- linear_acceleration: vec2 (vehicle relative)
||- angular_acceleration: vec2 (vehicle relative)
||- linear_jerk: vec2 (vehicle relative)
||- angular_jerk: vec2 (vehicle relative)

This is confusing because it is not clear

  • a) That velocity, acceleration, and jerk are coordinates relative to the vehicle front.
  • b) That the front-facing axis is x.

Proposal

Some suggestions:

  • Rename or reorient the hierarchy of the observations to clarify that the physics observations are relative.
  • Change the physics observations to be global.

Alternatives

No response

Additional context

No response

@Gamenot Gamenot added the enhancement New feature or request label Apr 27, 2023
@Gamenot Gamenot changed the title [Feature request] Feature request title [Feature request] Clarify relation between position and dynamics observations Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant