Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dependency issues for Colab #1436

Closed
Gamenot opened this issue May 20, 2022 · 2 comments · Fixed by #2080
Closed

Resolve dependency issues for Colab #1436

Gamenot opened this issue May 20, 2022 · 2 comments · Fixed by #2080
Labels
enhancement New feature or request

Comments

@Gamenot
Copy link
Collaborator

Gamenot commented May 20, 2022

Is your feature request related to a problem? Please describe.
Google Colab currently has dependency issues with SMARTS around grpcio and gym versions. For grpcio there is an issue where we are locked to a version 1.32.0 whereas colab comes with a different version. The same is true of gym since there is some difference in how gym works with the current version particularly around gym.make(..).

Describe the solution you'd like
Roughly we would like SMARTS to work with Colab without having to reload the dependencies. This means that SMARTS must be able to work correctly with the gym and grpcio versions embedded in the platform.

Additional context
There is a currently existing attempt #1300
Previous issue #1280

@AisenGinn

@Gamenot Gamenot added the enhancement New feature or request label May 20, 2022
@saulfield
Copy link
Contributor

This will be resolved when #1981 is completed.

@saulfield
Copy link
Contributor

This may be resolved now since grpcio and gym are no longer core dependencies in SMARTS.

@Gamenot Gamenot linked a pull request Jul 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants