Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration options #2

Open
armanbilge opened this issue Aug 22, 2022 · 0 comments
Open

Add configuration options #2

armanbilge opened this issue Aug 22, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@armanbilge
Copy link
Member

The general pattern for http4s clients is to have a builder, and use that to create the client.

That pattern will not work here, because the client is constructed for us by the runtime. Therefore a config data class CurlClientConfig would be the way to do this. It would be similar in spirit to IORuntimeConfig in that it should be possible to override in CurlApp.

There's some fun to scope out the various curl configuration options. There's also the question of client-level config vs request-level config, which we can expose with an attribute.

@armanbilge armanbilge added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 22, 2022
@armanbilge armanbilge pinned this issue Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant