Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainers wanted! #1

Open
armanbilge opened this issue May 2, 2022 · 11 comments
Open

Maintainers wanted! #1

armanbilge opened this issue May 2, 2022 · 11 comments
Labels
help wanted Extra attention is needed

Comments

@armanbilge
Copy link
Member

Please comment if you are interested in helping to maintain this module :) Thanks!

@armanbilge armanbilge added the help wanted Extra attention is needed label May 2, 2022
@armanbilge armanbilge pinned this issue May 2, 2022
@rossabaker rossabaker mentioned this issue Jan 4, 2023
Closed
@rossabaker
Copy link
Member

rossabaker commented Jan 4, 2023

I am planning to execute #41 next week unless someone steps up.

There's no need to be this aggressive, but I am marking it unmaintained along with some others.

@TonioGela
Copy link

@rossabaker @armanbilge I can maintain this module, as it seems there's not much work to do.
It will be my first "official" maintainer experience, so I will ask you for a few tips. Is that okay for you?

@armanbilge
Copy link
Member Author

I chatted with @TonioGela in Discord. Since they are not a user themselves, I'd rather let this project sit unmaintained until there is real demand (or just let it naturally EOL).

Meanwhile there are unmaintained projects such as http4s-okhttp-client which is a dependency of Scala Steward. If you are interested in building maintainer experience, I'd be happy to help you out there :)

@rossabaker
Copy link
Member

rossabaker commented Jan 5, 2023

I would caution that one is the most technically challenging of the five. I'll add some commentary to the unmaintained project discussion. Update: my rants and raves.

@TonioGela
Copy link

I would caution that one is the most technically challenging of the five. I'll add some commentary to the unmaintained project discussion. Update: my rants and raves.

So, to sum up:

  • async-http-client -> Why don't you use one of the many alternative backends?
  • boopickle -> just merging scala-steward PRs
  • dropwizard-metrics -> may be maintained but moving to prometheus or otel is advised
  • tomcat -> See async-http-client or use jetty
  • okhttp-client -> weird thread model and it's more worth investing in replacing it in Scala Steward with http4s-jdk-http-client as it supports proxy

To me, this substantiates more or less in a PR on Scala-Steward and merging PRs on dropwizard-metrics as it's the only tool that can't be hot-swapped with anything similar (prometeus is a different metric tool).

@rossabaker
Copy link
Member

That's a mostly fair summation. There are bridges between Dropwizard and Prometheus, but Dropwizard and Boopickle are the two on the list with the least direct alternatives.

@TonioGela
Copy link

That's a mostly fair summation. There are bridges between Dropwizard and Prometheus, but Dropwizard and Boopickle are the two on the list with the least direct alternatives.

Okay, so, if you, @armanbilge, other TL members think it's worth maintaining http4s-boopickle and http4s-dropwizard-metrics, I can take care of them (with a little kickstart babysitting from @armanbilge).
Otherwise, waiting for an actual user of these modules may be an option too.
(In the mean time I'll see if replacing the client impl in Scala-Steward it's feasible)

@rossabaker
Copy link
Member

My interest is more in developing new maintainers for organizational health than in these modules themselves. If these modules interest you, then it's a good fit for everyone.

Alternate idea: if you're interested in maintenance more than specific libraries, there are Typelevel ones that are relevant, similarly easy, and would help me to have help: jawn and jawn-fs2 come to mind.

@TonioGela
Copy link

TonioGela commented Jan 5, 2023

Alternate idea: if you're interested in maintenance more than specific libraries, there are Typelevel ones that are relevant, similarly easy, and would help me to have help: jawn and jawn-fs2 come to mind.

That's definitely more interesting. I'll take a look at those repos to get some more confidence with them. 😍

@cquiroz
Copy link
Member

cquiroz commented Jan 5, 2023

I could maintain http4s-boopickle

@rossabaker
Copy link
Member

rossabaker commented Jan 5, 2023

Cool! I think it was your contribution originally.

On most repos, we have series/* and main branches so we can support the production http4s (currently, 0.23.x) and development milestones (1.0.0-Mx). I haven't done that here yet. That could be achieved here by taking the current commit and branching off series/0.23.  That also gives you the latitude to cut an 0.24 if boopickle makes a breaking change before http4s-1.0 is production ready (there are several examples of this in other repos already). But ... it's your show.

I'll create the team to make sure you have the rights.

Also, you'll want to revert my changes to the README last night. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants