Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Conda install, dependencies #795

Open
breznak opened this issue Apr 19, 2020 · 4 comments · May be fixed by #796
Open

Improved Conda install, dependencies #795

breznak opened this issue Apr 19, 2020 · 4 comments · May be fixed by #796
Labels
build enhancement New feature or request question Further information is requested

Comments

@breznak
Copy link
Member

breznak commented Apr 19, 2020

@dkeeney I've recently been toying with our conda python install. Turns out I could be able to get most of the deps through conda (eigen, cereal, pybind11,..)

But our CMake would still try to install them from source. Would it be difficult to add a check "if exists, don't install from source"?

  • I don't want to replace our cmake self-contained build. As it's really convenient and tested. Works for porting to any new env.
  • The Conda alternative would be useful for cloud/server envs where one does not have priviledges to install any new SW, but conda is typically available (conda is also a sw manager/installer)
@breznak breznak added enhancement New feature or request question Further information is requested build labels Apr 19, 2020
@dkeeney
Copy link

dkeeney commented Apr 19, 2020

Yes I was thinking about that.
It will take some research to figure out how to 'test' before 'installing' using cmake.

Let me first finish setting up my Ubuntu 18.4 environment so I can make sure that still builds.

@breznak
Copy link
Member Author

breznak commented Apr 19, 2020

Something like cmake's find_package with conda env:
https://stackoverflow.com/questions/55934253/make-cmakes-find-packageboost-find-headers-inside-conda-environment

This is not urgent, but would be great if you could look into. As I hope we'll figure parameter optimization for NAB (#792 ) and then I'll abuse some of the university clusters for heavy computing ;)

@breznak breznak linked a pull request Apr 19, 2020 that will close this issue
Open
4 tasks
@breznak
Copy link
Member Author

breznak commented Apr 20, 2020

relevant snip

I also want to change our build to check to see if boost is installed locally before downloading and building boost. However, the downloading occurs at configure time and the find_package(Boost...) occurs at build time. So, to use the find_package before the download would be difficult. In addition, there are so many variations on how the boost package can be constructed that it might not work even if there is an existing Boost installation. So I decided it was probably not worth it. ~dkeeney

@breznak
Copy link
Member Author

breznak commented Jun 2, 2020

I'm wondering if I should work on this further.
PROs: simpler dependency management (our goal is not to support the install infrastructure)
CONs: dependant on conda -> limited platforms?. We(you) already have done the hard work and the cmake/setup dependencies works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP Conda env htm-community/htm.core
2 participants
@breznak @dkeeney