environment-protocols: Replace initialize-application-client

Instead of definiing an open generic function to be called by
run-application after instantiating the new <application>, add an
initialize-client: keyword argument to run-application for explicitly
passing a callback function.

* sources/environment/protocols/applications.dylan
  (run-application): Add an initialize-client keyword argument to
   the generic function definition.
  (initialize-application-client): Remove generic definition and
   default method.
  (run-application on <project-object>): Add an initialize-client:
   keyword argument, and call the referenced callback function
   in place of initialize-application-client.

* sources/environment/protocols/module.dylan
  (module environment-protocols): Remove export of
   initialize-application-client.

* documentation/source/hacker-guide/environment/environment-protocols.rst:
  Remove entry for initialize-application-client.

* sources/environment/dfmc/application/control-protocols.dylan
  (run-application on <dfmc-application>): Add a do-nothing
   initialize-client: keyword argument so that the method is congruent
   with the generic function definition.

* sources/environment/commands/application/debugging.dylan
  (do-execute-command on <start-application-command>): Explicitly
   pass in a initialize-client: callback.
  (initialize-application-client): Change method definition to a
   function.

Author: housel

documentation/source/hacker-guide/environment/environment-protocols.rst

@@ -3020,17 +3020,6 @@ Applications
 .. method:: run-application
    :specializer: <project-object>
 
-.. generic-function:: initialize-application-client
-   :open:
-
-   :signature: initialize-application-client (client application) => ()
-
-   :parameter client: An instance of :class:`<object>`.
-   :parameter application: An instance of :class:`<application>`.
-
-.. method:: initialize-application-client
-   :specializer: <object>, <application>
-
 .. generic-function:: attach-live-application
    :open:
 

sources/environment/commands/application/debugging.dylan

@@ -354,6 +354,7 @@ define method do-execute-command
     (context,
      run-application, project,
      client:                    context,
+     initialize-client:         initialize-application-client,
      machine:                   machine | unsupplied(),
      startup-option:            case
                                   debug?    => #"debug";
@@ -724,7 +725,7 @@ end method parse-next-argument;
 
 /// Application callbacks
 
-define sideways method initialize-application-client
+define function initialize-application-client
     (context :: <environment-context>, application :: <application>) => ()
   register-application-callbacks
     (application,
@@ -752,7 +753,7 @@ define sideways method initialize-application-client
                     application.application-filename);
           end,
           message-type: <run-application-failed-message>);
-end method initialize-application-client;
+end function initialize-application-client;
 
 
 define method start-debugging

sources/environment/dfmc/application/control-protocols.dylan

@@ -33,6 +33,7 @@ define method run-application
     (application :: <dfmc-application>,
      #key startup-option :: <symbol> = #"start",
           client,
+          initialize-client,
           filename :: false-or(<file-locator>),
           arguments :: false-or(<string>),
           process :: false-or(<process>) = #f,
@@ -44,6 +45,7 @@ define method run-application
           pause-before-termination? :: <boolean> = #f)
  => (application :: <dfmc-application>)
   ignore(client);
+  ignore(initialize-client);
 
   // A couple of conveniences for filename processing stolen from
   // the console debugger.

sources/environment/protocols/applications.dylan

@@ -108,6 +108,7 @@ define open generic run-application
     (server :: <server>,
      #key startup-option,
           client,
+          initialize-client,
           filename,
           arguments,
           pause-before-termination?,
@@ -116,9 +117,6 @@ define open generic run-application
           machine)
  => (application :: <application>);
 
-define open generic initialize-application-client
-    (client :: <object>, application :: <application>) => ();
-
 // There's no NOTE-RUN-APPLICATION-REQUESTED, we just do the relevant
 // work in RUN-APPLICATION.
 
@@ -183,11 +181,6 @@ define method perform-application-transaction
   end
 end method perform-application-transaction;
 
-define method initialize-application-client
-    (client :: <object>, application :: <application>) => ()
-  #f
-end method initialize-application-client;
-
 define method note-application-initialized
     (project :: <project-object>)
  => ()
@@ -260,6 +253,7 @@ define method run-application
     (project :: <project-object>,
      #key startup-option = #"start",
           client = project,
+          initialize-client :: <function> = ignore,
           filename,
           arguments,
           working-directory,
@@ -297,7 +291,7 @@ define method run-application
   end if;
   broadcast($project-channel,
             make(<run-application-requested-message>, project: project));
-  initialize-application-client(client, application);
+  initialize-client(client, application);
   let host-machine? = machine == environment-host-machine();
   run-application(application,
                   startup-option: startup-option,

sources/environment/protocols/module.dylan

@@ -387,7 +387,6 @@ define module environment-protocols
          find-application-proxy,
          application-proxy-id,
          run-application,
-         initialize-application-client,
          attach-live-application,
          note-run-application-failed,
          stop-application,