Replies: 9 comments 17 replies
-
I am very excited about this idea! Some thoughts on wording: "Name is required for a place" might lead to novice mappers adding random names to features to be able to upload their data. We often see novice mappers add names to features (i.e they will add their personal name or their company name to a building.) If they feel like they must add a name to move forward, they might add something completely arbitrary. "Building is not a square" might also lead novice mappers to think that their building MUST be a square regardless of what the imagery looks like. |
Beta Was this translation helpful? Give feedback.
-
Some questions and discussion points from the Tasking Manager Meet Up:
|
Beta Was this translation helpful? Give feedback.
-
Thanks for sharing, pdf feedback: Wording 'Building is not a square' should be reworded. Buildings are rarely 'square' they are more often 'rectangular'. The wording may confuse mappers into thinking they have to trace perfect 'squares' with equal length sides. I would recommend 'Building has un-squared corners' (which would align with the iD 'squaring' tool) or 'Building does not have right-angled corners'. Overlapping and duplicate buildings - how are these different? I'd argue in the visual example both are 'overlapping' buildings. Is there any need for a naming difference? The only instance where 'duplicate' term might be more relevant is if there is a building which shares the exact same footprint as another building. Implementation Can we define how this new check will be enabled and at which level? I'd argue that this should be enabled/disabled at the Tasking Manager project level (with it set to default on). Most projects will likely benefit from these checks, but for some more complex projects (e.g. a place naming project) it will be unsuitable. The checks The two semantic checks are not suitable for beginners or for remote mapping, I'd leave them disabled for now. I'd argue that places (e.g. settlement names) and roof material types are only added by experienced mappers, ideally on the ground. An impactful semantic check should focus on checking all of the fields for a building and flagging an issue if there is anything beyond 'building=yes'. This will catch a common error whereby new mappers fill building fields (e.g. name, or address) with meaningless text - typically tracking hashtags. Overlapping/duplicate buildings - there is already a check for this in iD, it is prompted as soon as the user traces the objects --> 'building crosses building': Will this be disabled and superseded? It is more powerful than your check because it recognizes overlap with all features immediately. But, the problem with this existing 'issue' check is that it prompts the users to change the building layer, which is almost never the correct thing to do. Will the new overlapping/duplicate building check ignore layer differences? (Which would be a good thing). Additional questions More info about your checks will be great. What happens after they are displayed - if you click on them does it jump to them? Does it block upload? How will they interact with the 'Warnings' and 'Errors' that already show in the save panel to the left? |
Beta Was this translation helpful? Give feedback.
-
Because the "Data quality checks warnings" do not indicate where the affected features are located, beginner mappers could possibly get confused. Besides from that, it would maybe enough to just limit the message to a warning for the mapper that iD Editor found issues. Show the pictures and text purely as examples of what the mapper should look for, and as an explanation on how to deal with these errors. But do not give detailed info about what and how many possible errors there are found. Refer the mapper to the iD Editor issues list instead for further actions. Then there would also be no problems with the wording. It would also prevent the situation that the iD Editor issues list and the "Data quality checks list" are not synchronized. |
Beta Was this translation helpful? Give feedback.
-
I am still not understanding what this is all about! Why are we reinventing the wheel? iD Editor already has the Issues function that warns mappers that they are making an error. We also have other tools like OSM Inspector, KeepRight, ImproveOSM, Osmose, to name a few. Would it not be better to concentrate on a tool that quantifies and reports the number of errors occurring on a project/campaign or area so that we can make better judgements on the quality of the mapping rather than trying to replace or overwrite the existing editor functions. Let's look at helping beginners to understand how to use the functions to understand how to fix errors they are making. |
Beta Was this translation helpful? Give feedback.
-
@RAytoun Main added value I see for this is that it notifies contributors at a very early stage about common quality issues that are currently not picked up in iD:
These two common issues are not picked up in the iD editor, and if HOT's version of iD had this check integrated it would be a value-add. It may lighten the load down-the-line for validation by prompting beginners to fix these issues themselves. |
Beta Was this translation helpful? Give feedback.
-
Presenting the mapper a list of errors is like duplicating the iD Editor issues list (reinventing the wheel). I have the impression beginner mappers often are not aware of the iD Editor issues list though, so a notification that there are issues would imo be useful (see also my previous comment). I agree with Ralph that focusing on a real-time tool to check mapping quality would be worthwhile. I hope this can happen on a task level: it would be great to have a sort of heat-map overlay over the project map so that it is immediatly visible which tasks have the most issues and need extra and/or immediate attention. But i realize that is belonging to another topic ("quality measurement - While uploading (live)"). |
Beta Was this translation helpful? Give feedback.
-
A lot of things have been shared already but I just wanted to add a few things where I see this new data quality module, can be useful in TM ecosystem:
Both the above points I believe will directly/indirectly contribute to people looking for improving their mapping and maintaining the data quality.
|
Beta Was this translation helpful? Give feedback.
-
Since this webpage shows an overview of (recent) mappings with both square and unsquared buildings it might be useful to show the task number in which the issues are mapped. Then it is easy to look through the OSMcha site to identify the changesets, comment to the mapper and correct them by opening the Task in TM4 and correct the issues on that particular task squared (both on ready for validation or 'more mappings needed. |
Beta Was this translation helpful? Give feedback.
-
Hi everyone, as part of the HOT efforts to improve the quality of the mapping, we're working on new tools for validation.
New feature: validation before uploading changes to the map
Starting on Q4 2022, we started to have meetings and to write down ideas for an end to end solution. The Data Team wrote the documents that are the stepping stone for definitions about data quality. At the Tech Team we wrote the technical documents and developed product ideas.
One of the ideas that caught the attention of many people is measuring data quality just before uploading the changes to the map. As we can process a set of changes, we can show warnings to the mappers about the Semantic and Positional Accuracy aspects.
This new proposed feature will analyze the changes when the user is on the "Upload" screen of the iD Editor, enabling automated data quality validation:
You can check the technical detail of this proposal on the PDF below:
https://drive.google.com/file/d/1FvSmjyDNFzXI53cVTnZB1F-SKP5siljC/view?usp=sharing
Validation
There are two different validation results that we'll show on the first alpha version that will be available for some users to test.
Bad geometry buildings
4-wall buildings that have not a squared geometry.
Wrong tagging
Data model validation using these YAML configuration files
https://github.com/hotosm/underpass/tree/master/validate
For example, if you see “building=no” is wrong tagging because there’s a file building.yaml and “building=no” is not listed on that file
Discussion: wording
This feature is in-progress, we're still developing all the software parts to enable it and we'll have several stages for testing it before making it available for all users into the Tasking Manager.
In the meanwhile, we can have discussions about it to make sure it fits the needs of the majority of Tasking Manager users, including mappers, project managers and validators.
What we want to discuss first is the wording of the messages that will be displayed to the user, for example "Building is not a square" or "Bad value for roof:material" , as some mappers can be discouraged to map or put any value for a tag just to get ride of these messages.
Let's start discussing it and make the map a better map!
Thanks :)
Beta Was this translation helpful? Give feedback.
All reactions