fix: Drop unnecessary / uninitialized form parameter

Author: ralflang

admin/alarms.php

@@ -44,7 +44,7 @@
 }
 
 if ($form->validate()) {
-    $info = $form->getInfo($vars, $info);
+    $info = $form->getInfo($vars);
     if (empty($info['alarm'])) {
         $info['alarm'] = strval(new Horde_Support_Uuid());
     }

admin/config/index.php

@@ -445,7 +445,7 @@ function _uploadFTP($params)
     $ftpform->addVariable(_("Password"), 'password', 'password', false);
 
     if ($ftpform->validate($vars)) {
-        $info = $ftpform->getInfo($vars, $info);
+        $info = $ftpform->getInfo($vars);
         $upload = _uploadFTP($info);
         if ($upload) {
             $notification->push(_("Uploaded all application configuration files to the server."), 'horde.success');

admin/user.php

@@ -59,7 +59,7 @@
     case 'add':
         $addForm->validate($vars);
         if ($addForm->isValid() && $vars->get('formname') == 'adduser') {
-            $info = $addForm->getInfo($vars, $info);
+            $info = $addForm->getInfo($vars);
 
             if (empty($info['user_name']) && isset($info['extra']['user_name'])) {
                 $info['user_name'] = $info['extra']['user_name'];

services/changepassword.php

@@ -33,7 +33,7 @@
 $form->addVariable(_("Retype new password"), 'password_2', 'password', true);
 
 if ($form->validate($vars)) {
-    $info = $form->getInfo($vars, $info);
+    $info = $form->getInfo($vars);
 
     if ($registry->getAuthCredential('password') != $info['old_password']) {
         $notification->push(_("Old password is not correct."), 'horde.error');

services/resetpassword.php

@@ -62,7 +62,7 @@
 
 /* Validate the form. */
 if ($can_validate && $form->validate($vars)) {
-    $info = $form->getInfo($vars, $info);
+    $info = $form->getInfo($vars);
 
     /* Fetch values from prefs for selected user. */
     $answer = $prefs->getValue('security_answer');

signup.php

@@ -31,7 +31,7 @@
     $notification->push(_("User Registration is not properly configured for this site."), 'horde.error');
     $registry->getServiceLink('login')->redirect();
 }
-
+$info = [];
 $vars = $injector->getInstance('Horde_Variables');
 $formsignup = new Horde_Core_Auth_Signup_Form($vars);
 if ($formsignup->validate()) {

src/Cli/SetupBundle.php

@@ -251,7 +251,7 @@ public function configAuth() {
         $this->_cli->writeln();
         $this->_cli->writeln($this->_cli->bold('Configuring global administrator settings'));
         // TODO: Move getting the factory to constructor
-        $auth = $GLOBALS['injector']->getInstance('Horde_Core_Factory_Auth')->create($vars->app ?? 'horde');
+        $auth = $GLOBALS['injector']->getInstance('Horde_Core_Factory_Auth')->create('horde');
         $atLeastOneAdminExists = false;
         while (!$atLeastOneAdminExists) {
             $adminUsers = $vars->auth__admins ?  explode(', ', $vars->auth__admins) : [];