Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should be able to resign a game (= become defeated on its own) #75

Open
CrsiX opened this issue Jun 2, 2023 · 3 comments
Open
Labels
prioritized Especially important ux Improvements to user experience

Comments

@CrsiX
Copy link
Member

CrsiX commented Jun 2, 2023

At the moment, it looks like neither the server nor the client checks if a player is still participating. We either need a new API endpoint for that or let the server inspect the uploaded game file.

What exactly happens at the moment?

@CrsiX CrsiX added api Suggestions for API enhancements prioritized Especially important labels Jun 2, 2023
@CrsiX
Copy link
Member Author

CrsiX commented Jun 3, 2023

If any of the players is defeated, they will still receive game updates, but won't be able to perform any moves and are not required to perform turns, i.e. the game will silently continue properly without any actions of them.

@CrsiX
Copy link
Member Author

CrsiX commented Jun 3, 2023

When somebody wins a game, it will currently remain on the server, so everybody else can still join the game. The winner will see the victory screen, but could also continue playing in single-player manner. However, the single-player experience is somewhat cumbersome at the moment, since the auto-detection that it's the current user's turn doesn't work (yet).

@CrsiX
Copy link
Member Author

CrsiX commented Jun 4, 2023

Winning is no problem after the patch I posted upstream.
Resigning is not implemented in the UI. This should be addressed in this issue.

@CrsiX CrsiX added ux Improvements to user experience and removed api Suggestions for API enhancements labels Jun 4, 2023
@CrsiX CrsiX changed the title What happens if a user wins a game or resigns? User should be able to resign a game (= become defeated on its own) Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prioritized Especially important ux Improvements to user experience
Projects
None yet
Development

No branches or pull requests

1 participant