Merge pull request #387 from hookdeck/chore/unit-tests

chore(ci): add GitHub Actions workflow for running unit tests

Author: leggetter

.github/workflows/unit-tests.yml

@@ -0,0 +1,18 @@
+name: Unit Tests
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.23.0'
+
+      - name: Run unit tests
+        run: make test/unit

internal/deliverymq/messagehandler_test.go

@@ -1224,18 +1224,28 @@ func TestMessageHandler_AlertMonitorError(t *testing.T) {
 	assert.Equal(t, models.DeliveryStatusSuccess, logPublisher.deliveries[0].Delivery.Status, "delivery status should be OK")
 
 	// Verify alert monitor was called but error was ignored
+	// Wait for the HandleAttempt call to be made
+	require.Eventually(t, func() bool {
+		for _, call := range alertMonitor.Calls {
+			if call.Method == "HandleAttempt" {
+				return true
+			}
+		}
+		return false
+	}, 200*time.Millisecond, 10*time.Millisecond, "timed out waiting for HandleAttempt call on alertMonitor")
 	alertMonitor.AssertCalled(t, "HandleAttempt", mock.Anything, mock.Anything)
 }
 
 // Helper function to assert alert monitor calls
 func assertAlertMonitor(t *testing.T, m *mockAlertMonitor, success bool, destination *models.Destination, expectedData map[string]interface{}) {
 	t.Helper()
 
-	// Wait a bit for goroutines
-	time.Sleep(100 * time.Millisecond)
+	// Wait for the alert monitor to be called
+	require.Eventually(t, func() bool {
+		return len(m.Calls) > 0
+	}, 200*time.Millisecond, 10*time.Millisecond, "timed out waiting for alert monitor to be called")
 
-	calls := m.Calls
-	require.NotEmpty(t, calls, "alert monitor should be called")
+	calls := m.Calls // m.Calls is now guaranteed to be non-empty
 
 	lastCall := calls[len(calls)-1]
 	attempt := lastCall.Arguments[1].(alert.DeliveryAttempt)