You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Versions
HoneycombWebSDK import in code: @honeycombio/opentelemetry-web version 0.10.0
OpenTelemetry span library: @honeycombio/instrumentation-global-errors version 0.10.0
Steps to reproduce
Unable to figure out due to this issue itself
Additional context
We recently added HoneycombWebSDK to our Nuxt/Vue 3 app and while it does report many reasonable-looking exceptions, there is one that stands out:
TypeError: ae is not iterable
at GlobalErrorsInstrumentation._computeStackTrace ([REDACTED].js:322:39022)
at GlobalErrorsInstrumentation.onError ([REDACTED].js:322:39539)
Since this is bundled code, I located the original source and it is here:
This suggests to me that computeStackTrace(error).stack is not filled in and indeed, looking through the code for https://github.com/csnover/TraceKit/blob/master/tracekit.js, all paths return mode, name, and message but only successful computations return stack
This library should cope with stack being missing from TraceKit, otherwise these unknown non-parsable stack traces prevent error instrumentation from being sent
The text was updated successfully, but these errors were encountered:
<!--
Thank you for contributing to the project! 💜
Please see our [OSS process
document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#)
to get an idea of how we operate.
-->
## Which problem is this PR solving?
- Closes#430
## Short description of the changes
Adds a guard for `stack === null` from `tracekit`. Also added unit test.
Versions
HoneycombWebSDK import in code:
@honeycombio/opentelemetry-web
version 0.10.0OpenTelemetry span library:
@honeycombio/instrumentation-global-errors
version 0.10.0Steps to reproduce
Additional context
We recently added HoneycombWebSDK to our Nuxt/Vue 3 app and while it does report many reasonable-looking exceptions, there is one that stands out:
Since this is bundled code, I located the original source and it is here:
honeycomb-opentelemetry-web/packages/honeycomb-opentelemetry-web/src/global-errors-autoinstrumentation.ts
Line 43 in 7645a8a
This suggests to me that
computeStackTrace(error).stack
is not filled in and indeed, looking through the code for https://github.com/csnover/TraceKit/blob/master/tracekit.js, all paths returnmode
,name
, andmessage
but only successful computations returnstack
This library should cope with
stack
being missing from TraceKit, otherwise these unknown non-parsable stack traces prevent error instrumentation from being sentThe text was updated successfully, but these errors were encountered: