Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"is not iterable" error in GlobalErrorsInstrumentation._computeStackTrace #430

Closed
twpol opened this issue Jan 13, 2025 · 0 comments · Fixed by #442
Closed

"is not iterable" error in GlobalErrorsInstrumentation._computeStackTrace #430

twpol opened this issue Jan 13, 2025 · 0 comments · Fixed by #442
Labels
type: bug Something isn't working

Comments

@twpol
Copy link

twpol commented Jan 13, 2025

Versions
HoneycombWebSDK import in code: @honeycombio/opentelemetry-web version 0.10.0
OpenTelemetry span library: @honeycombio/instrumentation-global-errors version 0.10.0

Steps to reproduce

  1. Unable to figure out due to this issue itself

Additional context

We recently added HoneycombWebSDK to our Nuxt/Vue 3 app and while it does report many reasonable-looking exceptions, there is one that stands out:

TypeError: ae is not iterable
    at GlobalErrorsInstrumentation._computeStackTrace ([REDACTED].js:322:39022)
    at GlobalErrorsInstrumentation.onError ([REDACTED].js:322:39539)

Since this is bundled code, I located the original source and it is here:

This suggests to me that computeStackTrace(error).stack is not filled in and indeed, looking through the code for https://github.com/csnover/TraceKit/blob/master/tracekit.js, all paths return mode, name, and message but only successful computations return stack

This library should cope with stack being missing from TraceKit, otherwise these unknown non-parsable stack traces prevent error instrumentation from being sent

@twpol twpol added the type: bug Something isn't working label Jan 13, 2025
wolfgangcodes added a commit that referenced this issue Jan 16, 2025
<!--
Thank you for contributing to the project! 💜
Please see our [OSS process
document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#)
to get an idea of how we operate.
-->

## Which problem is this PR solving?

- Closes
#430

## Short description of the changes
Adds a guard for `stack === null` from `tracekit`. Also added unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant