Multi-reddit navbar links are broken

[Kushagra-0801]

• My browser (copy from https://www.whatismybrowser.com): Firefox on Windows 10
• My RES version: 5.24.6
• Am I in reddit beta (yes/no): no

What's the problem?
The multi-reddit navbar links are broken.

Are there any related posts in https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues or /r/RESissues?
Couldn't find any.

What other browser extensions are installed?
Ublock Origin and a few more unrelated ones.

Possible root cause
In file (

Reddit-Enhancement-Suite/lib/modules/multiredditNavbar.js

Line 43 in bfbceb2

value: [

) the values are given as relative paths (./ prepended).

These are directly appended to the base url of the multi reddit (

Reddit-Enhancement-Suite/lib/modules/multiredditNavbar.js

Line 106 in bfbceb2

const li = string.html`<li><a href="${baseUrl}${url}">${label}</a></li>`;

), leading to broken links.

Suggestion

Use the following fragment for creating the element:

const normalizedBaseUrl = baseUrl.endsWith("/") ? baseUrl : baseUrl + "/";
const fullUrl = (new URL(url, normalizedBaseUrl)).href;
const li = string.html`<li><a href="${fullUrl}">${label}</a></li>`;

I would have made a PR but I do not have the setup on my laptop for running code.