Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page when purchasing is closed should be clearer #19

Open
hoelzro opened this issue Dec 6, 2011 · 4 comments
Open

Page when purchasing is closed should be clearer #19

hoelzro opened this issue Dec 6, 2011 · 4 comments

Comments

@hoelzro
Copy link
Owner

hoelzro commented Dec 6, 2011

When purchasing is closed for a conference and a user attempts to go to /$CONFERENCE/purchase, they encounter a 404 page with no real content. This is unclear and confusing to the user, and come to think of it, 404 is probably not the best status code for this.

@rizen
Copy link
Collaborator

rizen commented Dec 6, 2011

When purchasing is closed for a conference and a user attempts to go to /$CONFERENCE/purchase, they encounter a 404 page with no real content. This is unclear and confusing to the user, and come to think of it, 404 is probably not the best status code for this.

This should almost certainly be a 200 code, and should contain a reasonable default message about purchasing being closed. Perhaps something like:

Conference Registration Closed
You can no longer purchase a badge for this conference online. Instead, you may purchase a badge at the registration desk upon arrival.

@hoelzro
Copy link
Owner Author

hoelzro commented Dec 6, 2011

Is 200 really appropriate? The request is not really successful.

@rizen
Copy link
Collaborator

rizen commented Dec 6, 2011

Yes it was. The user received the page, and there's nothing either the user or the server would/could change about the result. It may not be the page they expected, but no error occurred on either the server or the browser. So this is simply informational.

On Dec 6, 2011, at 9:08 AM, Rob Hoelz wrote:

Is 200 really appropriate? The request is not really successful.


Reply to this email directly or view it on GitHub:
#19 (comment)

@hoelzro
Copy link
Owner Author

hoelzro commented Dec 6, 2011

Fair enough. 200 it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants