Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 75 changes the path to the KeystoneRegistration.framework #14

Open
sdpalmer opened this issue Jun 10, 2019 · 2 comments
Open

Chrome 75 changes the path to the KeystoneRegistration.framework #14

sdpalmer opened this issue Jun 10, 2019 · 2 comments

Comments

@sdpalmer
Copy link

The correct path is now /Applications/Google Chrome.app/Contents/Frameworks/Google Chrome Framework.framework/Frameworks/KeystoneRegistration.framework.

I don't know python as well, but I was able to figure out that I needed to change the keystone_registration_framework_path() subroutine to the following:

def keystone_registration_framework_path():
    """Returns KeystoneRegistration.framework path"""
    keystone_registration = os.path.join(chrome_path, 'Contents/Frameworks/Google Chrome Framework.framework/Frameworks/KeystoneRegistration.framework')
    return keystone_registration

I don't know enough, yet, to figure out how to make it work for both versions earlier than 75 and version 75 or later.

@ryangball
Copy link
Contributor

ryangball commented Jun 11, 2019

@sdpalmer This was corrected using the latest push, no?

The correct path for version 75.0.3770.80 is:
/Applications/Google Chrome.app/Contents/Frameworks/Google Chrome Framework.framework/Versions/75.0.3770.80/Frameworks/KeystoneRegistration.framework

You can see by running this command:
find /Applications/Google\ Chrome.app -name "KeystoneRegistration.framework"

@sdpalmer
Copy link
Author

sdpalmer commented Jun 11, 2019

@ryangball Yes, you are correct. Sorry. I had checked late last week and didn't see any changes and checked again earlier today before figuring what the cause was. However, this morning I only looked at the version history at the top of the script and seeing no changes listed I assumed there were no changes specific to Chrome 75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants