This repository has been archived by the owner on Oct 3, 2020. It is now read-only.
Add support for custom label names #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjacobs
reviewed
Jul 24, 2019
README.rst
Outdated
| Settings | ||
| -------- | ||
|
|
||
| You can run ``pipenv run python -m kube_resource_report --help`` to find out information. |
There was a problem hiding this comment.
I would use docker run ... --help here as this is easier for people (no need to install Pipenv)
There was a problem hiding this comment.
Done. I also do not know if this approach is "correct". I was also thinking about adding these guys as a click.option. But, it can be done in another step I think.
|
Thanks again 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#98