Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viteNodeInlineDeps replaces existing values #762

Open
6 tasks done
haakonmt opened this issue Sep 14, 2024 · 1 comment
Open
6 tasks done

viteNodeInlineDeps replaces existing values #762

haakonmt opened this issue Sep 14, 2024 · 1 comment
Labels
to triage This issue needs to be triaged

Comments

@haakonmt
Copy link

haakonmt commented Sep 14, 2024

Describe the bug

If the viteNodeInlineDeps option is set to anything, it completely replaces any value set by other sources, i.e. plugins. Most notably, this completely breaks Nuxt functionality, as all deps set by the Histoire Nuxt plugin are removed.

The reason this happens is due to the change introduced in this commit, but as I don't know the reasoning behind this change, it's difficult to say what else could be impacted by reverting it.

Reproduction

Add the following to the config in the default Nuxt StackBlitz berfore starting the dev server:

viteNodeInlineDeps: [],

System Info

System:
    OS: macOS 14.6.1
    CPU: (14) arm64 Apple M3 Max
    Memory: 99.98 MB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v20.11.1/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
    pnpm: 8.15.4 - ~/Library/pnpm/pnpm
    bun: 1.1.25 - ~/.bun/bin/bun
  Browsers:
    Chrome: 128.0.6613.138
    Safari: 17.6
  npmPackages:
    @histoire/plugin-nuxt: ^0.17.17 => 0.17.17 
    @histoire/plugin-vue: ^0.17.17 => 0.17.17 
    histoire: ^0.17.17 => 0.17.17 
    nuxt: ^3.13.0 => 3.13.0

Used Package Manager

yarn

Validations

@haakonmt haakonmt added the to triage This issue needs to be triaged label Sep 14, 2024
@haakonmt
Copy link
Author

This might be the root cause of #684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant