Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getProvider function #394

Open
friedger opened this issue Nov 8, 2024 · 3 comments
Open

Add getProvider function #394

friedger opened this issue Nov 8, 2024 · 3 comments
Assignees

Comments

@friedger
Copy link
Contributor

friedger commented Nov 8, 2024

Is your feature request related to a problem? Please describe.
When I have more than one extension installed, it is confusing which extension popups first.

Describe the solution you'd like
The library should provide a function that determines which extension to use, similar to https://github.com/friedger/stacks-send-many/blob/main/src/lib/getProvider.ts

Describe alternatives you've considered
Let the user experience bad UX

Additional context
Especially with asigna, users will have usually at least two extension installed.

Credits go to @hozzjss

@janniks
Copy link
Collaborator

janniks commented Nov 11, 2024

The popup first should be fixed by selecting providers via the connect-ui. If developers don't want to use the UI, that's fine. But this implementation seems very strict. There might be more multisig providers, users trying to use leather may not have the provider set, etc.

The getProviderFromId(string) function can be used to make it easier for site to use an exact provider — does that help?

@janniks
Copy link
Collaborator

janniks commented Nov 11, 2024

I feel this is an important issue so I'd like to chat more and get it right! Will think about it more

@hozzjss
Copy link

hozzjss commented Nov 11, 2024

If there's a way to select the provider on log in through the popup or at least if there was a walletProvider property in the profile for each wallet then we might be able to have a solution, current wallets just fight over the StacksProvider global variable, both devs and users are frustrated by this inconsistency, not saying that this is the connect library's fault, I just wanna point out that there must be some consistency between wallets so that the UX can be consistent

@smcclellan smcclellan moved this from 🆕 New to 📋 Backlog in DevTools Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants