From 28d81f192f904b067e2e64bebd9cf3f203002cc9 Mon Sep 17 00:00:00 2001
From: Charlie <2747302+CharlieC3@users.noreply.github.com>
Date: Tue, 19 Dec 2023 09:30:20 -0500
Subject: [PATCH] fix: max old space and remove unused argument (#16)

* fix: use max old space in NODE_OPTIONS env var and remove unused argument

* fix: add back parquet workers

* chore: update chart version
---
 hirosystems/stacks-blockchain-api/Chart.lock                | 6 +++---
 hirosystems/stacks-blockchain-api/Chart.yaml                | 4 ++--
 .../templates/api-writer/statefulset.yaml                   | 3 ++-
 hirosystems/stacks-blockchain-api/values.yaml               | 6 +++---
 4 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/hirosystems/stacks-blockchain-api/Chart.lock b/hirosystems/stacks-blockchain-api/Chart.lock
index 4dcbd40..9780d17 100644
--- a/hirosystems/stacks-blockchain-api/Chart.lock
+++ b/hirosystems/stacks-blockchain-api/Chart.lock
@@ -7,6 +7,6 @@ dependencies:
   version: 12.12.10
 - name: common
   repository: https://charts.bitnami.com/bitnami
-  version: 2.13.3
-digest: sha256:e92d8594e35b2f1807661f0474e5ac1a2deaac8a53493a6b6a94c0525651b78d
-generated: "2023-10-25T12:35:40.790461-04:00"
+  version: 2.13.4
+digest: sha256:fd38f9210e9d3df51df7faad5dfabd1711120840fc90be25b5d9c6bf58da6fcf
+generated: "2023-12-15T10:34:06.093471-05:00"
diff --git a/hirosystems/stacks-blockchain-api/Chart.yaml b/hirosystems/stacks-blockchain-api/Chart.yaml
index 01ea575..1b7401b 100644
--- a/hirosystems/stacks-blockchain-api/Chart.yaml
+++ b/hirosystems/stacks-blockchain-api/Chart.yaml
@@ -1,7 +1,7 @@
 annotations:
   category: ApplicationServer
 apiVersion: v2
-appVersion: 7.3.2
+appVersion: 7.3.6
 dependencies:
   - condition: stacks-blockchain.enabled
     name: stacks-blockchain
@@ -41,4 +41,4 @@ sources:
   - https://github.com/hirosystems/stacks-blockchain-api
   - https://docs.hiro.so/api
   - https://docs.hiro.so/get-started/stacks-blockchain-api
-version: 5.0.1
+version: 5.0.2
diff --git a/hirosystems/stacks-blockchain-api/templates/api-writer/statefulset.yaml b/hirosystems/stacks-blockchain-api/templates/api-writer/statefulset.yaml
index a75bb85..f35a80e 100644
--- a/hirosystems/stacks-blockchain-api/templates/api-writer/statefulset.yaml
+++ b/hirosystems/stacks-blockchain-api/templates/api-writer/statefulset.yaml
@@ -271,6 +271,8 @@ spec:
                   fieldPath: metadata.name
             - name: PG_CONNECTION_POOL_MAX
               value: {{ default "50" .Values.apiWriter.config.pgConnectionPoolMax | quote }}
+            - name: NODE_OPTIONS
+              value: {{ printf "--max-old-space-size=%d" (int .Values.apiWriter.config.replayEvents.maxOldSize) | quote }}
             {{- if .Values.apiWriter.extraEnvVars }}
             {{- include "common.tplvalues.render" (dict "value" .Values.apiWriter.extraEnvVars "context" $) | nindent 12 }}
             {{- end }}
@@ -289,7 +291,6 @@ spec:
           - "./lib/index.js"
           - "from-parquet-events"
           - {{ printf "--workers=%d" (int .Values.apiWriter.config.replayEvents.workers) | quote }}
-          - {{ printf "--max-old-space-size=%d" (int .Values.apiWriter.config.replayEvents.maxOldSize) | quote }}
           {{- if .Values.apiWriter.initContainerSecurityContext.enabled }}
           securityContext: {{- omit .Values.apiWriter.initContainerSecurityContext "enabled" | toYaml | nindent 12 }}
           {{- end }}
diff --git a/hirosystems/stacks-blockchain-api/values.yaml b/hirosystems/stacks-blockchain-api/values.yaml
index d5d991e..c7ebf81 100644
--- a/hirosystems/stacks-blockchain-api/values.yaml
+++ b/hirosystems/stacks-blockchain-api/values.yaml
@@ -114,7 +114,7 @@ apiWriter:
   image:
     registry: docker.io
     repository: hirosystems/stacks-blockchain-api
-    tag: 7.3.2
+    tag: 7.3.6
     ## Specify a imagePullPolicy
     ## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent'
     ## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images
@@ -610,7 +610,7 @@ apiReader:
   image:
     registry: docker.io
     repository: hirosystems/stacks-blockchain-api
-    tag: 7.3.2
+    tag: 7.3.6
     ## Specify a imagePullPolicy
     ## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent'
     ## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images
@@ -968,7 +968,7 @@ apiRosettaReader:
   image:
     registry: docker.io
     repository: hirosystems/stacks-blockchain-api
-    tag: 7.3.2
+    tag: 7.3.6
     ## Specify a imagePullPolicy
     ## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent'
     ## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images