Skip to content

Commit f9711da

Browse files
authored
Merge pull request #24 from hipeople/chore/i-hate-the-groups-table
fix: error running unquoted table
2 parents 510b5b6 + 9707954 commit f9711da

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

sql/table.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,15 +141,15 @@ func SelectQuery(tableName string, columnNames []string) string {
141141
}
142142

143143
func UpdateQuery(tableName, index string, columnNames []string) string {
144-
return fmt.Sprintf("%s WHERE %s=?", UpdateAllQuery(tableName, columnNames), index)
144+
return fmt.Sprintf("%s WHERE `%s`=?", UpdateAllQuery(tableName, columnNames), index)
145145
}
146146

147147
func UpdateAllQuery(tableName string, columnNames []string) string {
148148
return fmt.Sprintf("UPDATE `%s` SET %s=?", tableName, strings.Join(quoteColumnNames(columnNames), "=?, "))
149149
}
150150

151151
func DeleteQuery(tableName, index string) string {
152-
return fmt.Sprintf("DELETE FROM `%s` WHERE %s=?", tableName, index)
152+
return fmt.Sprintf("DELETE FROM `%s` WHERE `%s`=?", tableName, index)
153153
}
154154

155155
func quoteColumnNames(columns []string) []string {

sql/table_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ func TestInsertBulkQuery(t *testing.T) {
9595
}
9696

9797
func TestUpdateQuery(t *testing.T) {
98-
assert.Equal(t, sql.UpdateQuery("yolo", "id", []string{"name", "email", "age"}), "UPDATE `yolo` SET `name`=?, `email`=?, `age`=? WHERE id=?")
98+
assert.Equal(t, sql.UpdateQuery("yolo", "id", []string{"name", "email", "age"}), "UPDATE `yolo` SET `name`=?, `email`=?, `age`=? WHERE `id`=?")
9999
}
100100

101101
func TestDeleteQuery(t *testing.T) {
102-
assert.Equal(t, sql.DeleteQuery("yolo", "id"), "DELETE FROM `yolo` WHERE id=?")
102+
assert.Equal(t, sql.DeleteQuery("yolo", "id"), "DELETE FROM `yolo` WHERE `id`=?")
103103
}

0 commit comments

Comments
 (0)