-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed highlight C++ std types in C #4107
Conversation
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +74 B View Changes
|
Could we break this into two commits please, the first one just rewriting the keywords to be one per line (see some of the newer grammars), then the second actually making the changes - this way it's possible to review a diff and actually see what was changed - which is very difficult now. I used to have a VS Code plugin for this but I think I've lost it. |
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +63 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +5 B View Changes
|
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +72 B View Changes
|
done but the order might still give you should i sort it add two commits for easier diffing |
@joshgoebel should i sort this alphabetically for easier diffing ? |
@joshgoebel or should i break up the whole thing into different lists for easier diffing ? |
To even review this this would need to only include the C changes, not all the SQL stuff. |
+ 'strcpy strcspn strlen strncat strncmp strncpy strpbrk strrchr strspn strstr tanh tan ' | ||
+ 'vfprintf vprintf vsprintf endl initializer_list unique_ptr', | ||
literal: | ||
'true ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should now be an array (one item per line), not a large string.
Closing for inactivity and multiple grammar changes in a single PR. This needs to be a PR from a branch with ONLY the C grammar changes. This can be reopened at any time you have the time to submit a new PR with isolated changes and address the questions asked. |
Resolves #4103
added C lingo and rm C++ lingo
Checklist