Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed highlight C++ std types in C #4107

Closed
wants to merge 5 commits into from
Closed

Conversation

Dxuian
Copy link
Contributor

@Dxuian Dxuian commented Aug 30, 2024

Resolves #4103

added C lingo and rm C++ lingo

Checklist

  • Added markup tests, or they don't apply here because...

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

7 files changed

Total change +74 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
es/languages/c.min.js 1.97 KB 2 KB +34 B
es/languages/sql.min.js 2.44 KB 2.44 KB +1 B
highlight.min.js 8.22 KB 8.22 KB +2 B
languages/c.min.js 1.97 KB 2.01 KB +34 B
languages/sql.min.js 2.44 KB 2.44 KB +1 B

@joshgoebel
Copy link
Member

Could we break this into two commits please, the first one just rewriting the keywords to be one per line (see some of the newer grammars), then the second actually making the changes - this way it's possible to review a diff and actually see what was changed - which is very difficult now.

I used to have a VS Code plugin for this but I think I've lost it.

Copy link

github-actions bot commented Sep 1, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

7 files changed

Total change +63 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -2 B
es/highlight.min.js 8.18 KB 8.18 KB -2 B
es/languages/c.min.js 1.97 KB 2 KB +33 B
es/languages/sql.min.js 2.44 KB 2.44 KB +1 B
highlight.min.js 8.22 KB 8.22 KB -1 B
languages/c.min.js 1.97 KB 2.01 KB +33 B
languages/sql.min.js 2.44 KB 2.44 KB +1 B

Copy link

github-actions bot commented Sep 1, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +5 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
es/languages/sql.min.js 2.44 KB 2.44 KB +1 B
highlight.min.js 8.22 KB 8.22 KB +1 B
languages/sql.min.js 2.44 KB 2.44 KB +1 B

Copy link

github-actions bot commented Sep 1, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

7 files changed

Total change +72 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
es/languages/c.min.js 1.97 KB 2 KB +33 B
es/languages/sql.min.js 2.44 KB 2.44 KB +1 B
highlight.min.js 8.22 KB 8.22 KB +2 B
languages/c.min.js 1.97 KB 2.01 KB +33 B
languages/sql.min.js 2.44 KB 2.44 KB +1 B

@Dxuian
Copy link
Contributor Author

Dxuian commented Sep 1, 2024

Could we break this into two commits please, the first one just rewriting the keywords to be one per line (see some of the newer grammars), then the second actually making the changes - this way it's possible to review a diff and actually see what was changed - which is very difficult now.

I used to have a VS Code plugin for this but I think I've lost it.

done but the order might still give you should i sort it add two commits for easier diffing
also please review my other prs 🙏🙏
pr1
pr2
pr3

@Dxuian
Copy link
Contributor Author

Dxuian commented Sep 29, 2024

@joshgoebel should i sort this alphabetically for easier diffing ?

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 3, 2024

Could we break this into two commits please, the first one just rewriting the keywords to be one per line (see some of the newer grammars), then the second actually making the changes - this way it's possible to review a diff and actually see what was changed - which is very difficult now.

I used to have a VS Code plugin for this but I think I've lost it.

@joshgoebel or should i break up the whole thing into different lists for easier diffing ?
(can you add hacktoberfest to the issue 🙏🙏🙏)

@joshgoebel
Copy link
Member

To even review this this would need to only include the C changes, not all the SQL stuff.

@joshgoebel joshgoebel added the hacktoberfest-accepted Hacktoberfest label Oct 31, 2024
+ 'strcpy strcspn strlen strncat strncmp strncpy strpbrk strrchr strspn strstr tanh tan '
+ 'vfprintf vprintf vsprintf endl initializer_list unique_ptr',
literal:
'true '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now be an array (one item per line), not a large string.

@joshgoebel
Copy link
Member

Closing for inactivity and multiple grammar changes in a single PR. This needs to be a PR from a branch with ONLY the C grammar changes. This can be reopened at any time you have the time to submit a new PR with isolated changes and address the questions asked.

@joshgoebel joshgoebel closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(C) Don't highlight C++ std types
2 participants