Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CORS and AC to Achieve #2

Open
highlevellogic opened this issue Dec 21, 2020 · 0 comments
Open

Move CORS and AC to Achieve #2

highlevellogic opened this issue Dec 21, 2020 · 0 comments

Comments

@highlevellogic
Copy link
Owner

highlevellogic commented Dec 21, 2020

Achieve was first built for use in a beginning programming course. Students worked on localhost and did not have admin privileges to open their system to external clients. The work being done in relation to achieve-proxy has opened this issue for serious consideration. Achieve is sufficiently well developed that it may be considered for "serious" use in production.

Early release of achieve-proxy included opening CORS (preflight - all OPTIONS requests) with * access. Whether this signal is honored depends on access controls in proxy servlets. Maybe even early release should somehow respond so that the preflight signal is honored - i.e. without CORS violation. (Should at least be illustrated in example - customization.)

Current work aims only at controlling access to proxy servlets and CORS is only part of the story. The bigger question is whether ALL access control should be moved from achieve-proxy to achieve. As achieve-proxy aims to allow web apps and proxies in the same server instance, more thought needs to be given to securing the entire system.

Related issue #1 deals with identifying external clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant