Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn the user & ask for confirmation when installing on untested OS verions #4185

Open
someonemax opened this issue Jun 11, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@someonemax
Copy link

someonemax commented Jun 11, 2024

Describe the bug
When installing on Ubuntu 24.04 there is no warning / request for confirmation that this version is untested.
Installing the script on this version results in HaProxy service not working.

To Reproduce
Steps to reproduce the behavior:

  1. Install Ubuntu 24.04
  2. Run: bash <(curl i.hiddify.com/release)

Expected behavior
The script should warn the user that their OS version is untested and might not work, and should ask for confirmation.
But it doesn't and will happily try to install the panel, which will be unsuccessful.
Because HaProxy service won't start on this version of the OS.

@Iam54r1n4 Iam54r1n4 added good first issue Good for newcomers enhancement New feature or request help wanted Extra attention is needed labels Jun 15, 2024
@Iam54r1n4
Copy link
Contributor

Iam54r1n4 commented Jun 15, 2024

First of all, thank you for the report. Currently, I'm a little busy, but as you probably know, PRs are always welcome. If no one submits a PR, I will make the changes myself.
P.S: Relevant code: here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants