Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added multi lingual support for Oceanic calendar's weeknames #161

Closed
wants to merge 1 commit into from
Closed

Added multi lingual support for Oceanic calendar's weeknames #161

wants to merge 1 commit into from

Conversation

gsrathoreniks
Copy link
Contributor

Closes #160

Afolayan
Afolayan reviewed Oct 5, 2023
View reviewed changes
Copy link

@Afolayan Afolayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your branch name reads fix/Oceanic_language, but the changes are in KalendarFirey.kt. This is a bit confusing.
According to the linked issue, Firey is already localised but Oceanic is not. Can you clarify this?

@gsrathoreniks
Copy link
Contributor Author

@Afolayan I created the branch based on #160 where it was wrongly mentioned between the two. I guess I forgot to rename the branch before pushing.

@Afolayan
Copy link

Afolayan commented Oct 6, 2023

Would you be able to rename the branch for clarity, so we can merge this PR?

@gsrathoreniks
Copy link
Contributor Author

@Afolayan
Changed name and created new PR #165
we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Afolayan Afolayan Afolayan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing the week value(mon~sun) is different of two view
2 participants
@gsrathoreniks @Afolayan