{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":95602123,"defaultBranch":"main","name":"hsl","ownerLogin":"hhvm","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-06-27T21:24:01.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4553654?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1639604049.0373719","currentOid":""},"activityList":{"items":[{"before":"d24211f8c1072f159eabeff2c56568291330f844","after":"3ef529561421935e7b2990e83e9c77cb12308e2c","ref":"refs/heads/main","pushedAt":"2024-09-12T12:44:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Allow to use HH_IGNORE to silence warnings instead of HH_FIXME\n\nSummary:\nUsing HH_FIXME to silence errors is not satisfactory for multiple reasons:\n* The user usually wants to mark a warning as \"please ignore I know what I'm doing\" rather than \"fix this later\". HH_IGNORE conveys that intention better.\n* We don't want users to get into the habit of adding HH_FIXMEs and think it's a fine common thing to do.\n\nTherefore this diff requires HH_IGNORE to suppress warnings instead of HH_FIXME. If the user attempts using HH_FIXME, they'll get an error requiring them to use HH_IGNORE instead. We also check that HH_IGNORE can only be applied to warning codes.\n\nReviewed By: madgen\n\nDifferential Revision: D62188724\n\nfbshipit-source-id: a736a56ccab9b901331f39bd89d4c0874c2597bd","shortMessageHtmlLink":"Allow to use HH_IGNORE to silence warnings instead of HH_FIXME"}},{"before":"7acff09792e9d0a066124dfb3f1e5c10913ce265","after":"d24211f8c1072f159eabeff2c56568291330f844","ref":"refs/heads/main","pushedAt":"2024-09-04T12:30:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"hack_warnings = true by default\n\nSummary: hack_warnings is already turned on in JK. We make it true by default so that all paths not reading JK also have hack warnings. This concerns mostly dev builds of hack\n\nReviewed By: madgen\n\nDifferential Revision: D62124823\n\nfbshipit-source-id: c7970d93808542683366fcb6eeaca65ca3ef1f89","shortMessageHtmlLink":"hack_warnings = true by default"}},{"before":"d41f5937c1b1a92d880ef5556e6d88e3684f2ab8","after":"7acff09792e9d0a066124dfb3f1e5c10913ce265","ref":"refs/heads/main","pushedAt":"2024-08-31T03:17:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"make generic names in Keyset\\map_async more consistent\n\nSummary:\n`Keyset\\map_async` uses `Awaitable<keyset<Tk>>` for its return type, but this isn't consistent with how other mapping functions name their generics (`Tv1` maps to `Tv2`).\n\n`Keyset\\map` has the definition `function map<Tv1, Tv2 as arraykey>`\n`Vec\\map` has the definition `async function map_async<Tv1, Tv2>`\n\nReviewed By: admdikramr\n\nDifferential Revision: D62051033\n\nfbshipit-source-id: 63e9dc71af248a53c73476e45c3f7847c572dc5e","shortMessageHtmlLink":"make generic names in Keyset\\map_async more consistent"}},{"before":"8623f4f53d5e822dece406d4369ebfb09e4ab73d","after":"d41f5937c1b1a92d880ef5556e6d88e3684f2ab8","ref":"refs/heads/main","pushedAt":"2024-07-26T16:37:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update the documentation for sort comparators\n\nSummary:\nUpdating the documentation for the following methods to provide context on the expectated behavior of the comparator.\n- `Vec\\sort`, `Vec\\sort_by`\n- `Dict\\sort`, `Dict\\sort_by`, and `Dict\\sort_by_key`\n- `Keyset\\sort`\n- `C\\is_sorted`, `C\\is_sorted_by`\n\nReviewed By: viratyosin\n\nDifferential Revision: D60239279\n\nfbshipit-source-id: b6a20011128b4c8d46e30c69e1fdaf02e97c5846","shortMessageHtmlLink":"Update the documentation for sort comparators"}},{"before":"54c3381217ff5f5fd544d7264f5631e7d57c3ab6","after":"8623f4f53d5e822dece406d4369ebfb09e4ab73d","ref":"refs/heads/main","pushedAt":"2024-07-17T11:47:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make some OCaml/Rust parser option defaults consistent\n\nSummary: Unify default config options between Rust and OCaml\n\nReviewed By: andrewjkennedy\n\nDifferential Revision: D59809221\n\nfbshipit-source-id: 1aae4810142feb7a6535b313b61dbeed27bc6ef9","shortMessageHtmlLink":"Make some OCaml/Rust parser option defaults consistent"}},{"before":"ea969910efb6993add211b2362f39590041610a0","after":"54c3381217ff5f5fd544d7264f5631e7d57c3ab6","ref":"refs/heads/main","pushedAt":"2024-07-11T17:10:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Read experimental feature status from config (step 1)\n\nSummary:\nAdd a field to `.hhconfig` named `enable_experimental_stx_features`. It contains a json mapping experimental feature names to their status. For example,\n`enable_experimental_stx_features = {\"union_intersection_type_hints\": \"Unstable\", \"readonly\": \"Preview\"}`. This is in preparation to move the configuration of experimental features out of the source code and into `.hhconfig` and `.hhvmconfig.hdf`.\n\nCurrently, we enforce that any feature specified in `enable_experimental_stx_features` has the same status as the hard-coded status, to ensure hh and hhvm stay in sync until we are ready to complete the migration.\n\nThere are 2 other configuration options:\n- `consider_unspecified_experimental_features_released`: if an experimental feature is not listed in the config, should it default to `OngoingRelease`, or `Unstable` status. We set `hh_server` to `Unstable`, but allow all other tools (`hh_single_type_check`, `hh_parse`, `hackfmt`, etc.) to default to `OngoingRelease` since we expect them to have empty lists of experimental features as they don't read `.hhconfig`, and we don't need them to reject experimental features.\n- `use_legacy_experimental_feature_config`: determines whether to use the new config-based mechanism, or the old hardcoded one. It is set to use the new mechanism for `hh_server`, and `hh_single_type_check`, and use the hardcoded mechanism for everything else. As we migrate, we will set this to the new mechanism for a wider range of entry points, and finally remove it altogether.\n\nReviewed By: CatherineGasnier\n\nDifferential Revision: D58869349\n\nfbshipit-source-id: 43dd1d375d56540db709a8608eeaad6ea0c61311","shortMessageHtmlLink":"Read experimental feature status from config (step 1)"}},{"before":"ed8f8b01c95a7f618c725b83089d89ddd80c4033","after":"ea969910efb6993add211b2362f39590041610a0","ref":"refs/heads/main","pushedAt":"2024-07-10T22:44:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"correct Dict\\from_keys documentation\n\nSummary:\nI was reading the [`Dict\\from_keys` ](https://docs.hhvm.com/hsl/reference/function/HH.Lib.Dict.from_keys/)  documentation and noticed that `Dict\\from_key_async` doesn't exist.\n\nThis diff fixes it by adding the correct function.\n\nCreated from CodeHub with https://fburl.com/edit-in-codehub\n\nReviewed By: voorka\n\nDifferential Revision: D59576197\n\nfbshipit-source-id: a3d5f12013dadd84df18537d1d9aff6e36fb0279","shortMessageHtmlLink":"correct Dict\\from_keys documentation"}},{"before":"afedd6570483f9412743d35ba23e57dc77b0d16c","after":"ed8f8b01c95a7f618c725b83089d89ddd80c4033","ref":"refs/heads/main","pushedAt":"2024-07-10T18:48:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix Vec\\intersect() generator bug\n\nSummary:\nI ran across this testing something. `Vec\\intersect()` doesn't work when the first parameter is a generator:\n\n```\nfbdbg> $s = Streams::filter(Vec\\range(1, 10), $x ==> true)\nfbdbg> =Vec\\intersect($s, vec[5])\nHit a php exception : exception 'Exception' with message 'Generator is already finished' in /data/sandcastle/boxes/www/flib/core/hack/lib/hsl_generated/vec/select.php:168\nStack trace:\n#0 (): Generator->rewind()\n#1 (): HH\\Lib\\Vec\\filter()\n#2 /data/sandcastle/boxes/www/flib/core/hack/lib/hsl_generated/vec/select.php(168): HH\\Lib\\Vec\\intersect()\n#3 (1): FlibSL\\Vec\\intersect()\n#4 (1): include()\n#5 (): include()\n#6 {main}\nHit a php exception : exception 'Exception' with message 'Generator is already finished' in /data/sandcastle/boxes/www/flib/core/hack/lib/hsl_generated/vec/select.php:168\nStack trace:\n#0 (): Generator->rewind()\n#1 (): HH\\Lib\\Vec\\filter()\n#2 /data/sandcastle/boxes/www/flib/core/hack/lib/hsl_generated/vec/select.php(168): HH\\Lib\\Vec\\intersect()\n#3 (1): FlibSL\\Vec\\intersect()\n#4 (1): include()\n#5 (): include()\n#6 {main}\nFailed to evaluate expression\n```\n\nThe cause is that it iterates over the generator again after `Keyset\\intersect()` has been called.\n\nhttps://www.internalfb.com/code/fbsource/[4e26eed969060508bfbd3c4f675e018ca367c556]/fbcode/hphp/hsl/src/vec/select.php?lines=186-189\n\nReviewed By: viratyosin\n\nDifferential Revision: D59356423\n\nfbshipit-source-id: 8ec1b5d00183d09606728c97d61bf30a26bfdf1c","shortMessageHtmlLink":"Fix Vec\\intersect() generator bug"}},{"before":"c2ed718280a56565fb28f67e44ab8b309c7ba020","after":"afedd6570483f9412743d35ba23e57dc77b0d16c","ref":"refs/heads/main","pushedAt":"2024-06-12T14:37:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add loose typing to debug_backtrace\n\nSummary:\nSorry if this is not valid or the right way to do this, but I figured it'd be easiest to just try it out and get feedback. To motivate this change, I recently foolishly assumed `args` would always be present in a frame, which broke a bunch of stuff (D57301367). I think the demographic of folks who typically work closely with stacks would be familiar with this fickleness of frame data, but alas, as a noob I didn't have this intuition. It would've been helpful to have some typing to guide me in the right direction of using `idx` or foregoing the usage of the data entirely.\n\nI based my typing off of [this docblock](https://www.internalfb.com/code/fbsource/[8eec5a24f012]/fbcode/hphp/runtime/ext/std/ext_std_errorfunc.php?lines=20-30) (which is almost certainly outdated, as seen by the omission of `metadata`) and [the code that generates the stack](https://fburl.com/code/0htc79f2). I opted for incredibly loose typing so as to not break anything. I know this is maybe *so* loose that it gives us almost no extra type safety, but I'm hoping that all the optional typing shows that nothing in the stack is guaranteed. If there is anything in the stack that you know is guaranteed, let me know and I can tighten it a bit.\n\nReviewed By: mheiber\n\nDifferential Revision: D57509960\n\nfbshipit-source-id: 0c0fca48082f580255a125daed78918862d0ee8b","shortMessageHtmlLink":"Add loose typing to debug_backtrace"}},{"before":"71500e5046f3576a0a3a4cb2fd02b75dfb20fc10","after":"c2ed718280a56565fb28f67e44ab8b309c7ba020","ref":"refs/heads/main","pushedAt":"2024-06-04T21:05:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deprecate the varray darray function\n\nSummary:\nWe have been codemodding varray() darray() away for a long time.\n\nLets mark this for removal in the HHI.\n\nDifferential Revision: D57815717\n\nfbshipit-source-id: c684494f69b350c5a5727437d66a53ef6400a571","shortMessageHtmlLink":"Deprecate the varray darray function"}},{"before":"df4592ec0416aee7c9b758de56d7bd0f6443bf3a","after":"71500e5046f3576a0a3a4cb2fd02b75dfb20fc10","ref":"refs/heads/main","pushedAt":"2024-04-09T19:04:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"make Str\\replace_every_nonrecursive pure\n\nSummary:\nWhile trying to optimize a function by switching `Str\\replace_every` for `Str\\replace_every_nonrecursive`, I was met with an error that this function required the default capabilities (D55895227)\n\n```\nflib/privacy/asset_xid/AssetXID.php line 167 col 7-36: This call is not allowed because its capabilities are incompatible with the context\n  flib/privacy/asset_xid/AssetXID.php line 165 col 4-5: From this declaration, the context of this function body provides the capability set {}\n  flib/core/hack/lib/hsl_manual/str.php line 211 col 10-35: But the function being called requires the capability set {AccessGlobals, IO, ImplicitPolicyLocal, RxLocal, SystemLocal, WriteProperty}\n```\n\nI found that to be odd that `Str\\replace_every` is pure but `Str\\replace_every_nonrecursive` is not. After digging a bit I see a diff, D34555209, that removed the need for rx from the capability set but did not make the set empty (thereby requiring all the defaults instead)\n\nI believe this function should be pure as it does not need any more capabilities than its `Str\\replace_every` equivalent\n\nReviewed By: viratyosin\n\nDifferential Revision: D55897982\n\nfbshipit-source-id: 992e761dcb4ca2c5bc2416a1fa4b4587f7c0f2d7","shortMessageHtmlLink":"make Str\\replace_every_nonrecursive pure"}},{"before":"bcbf500d87781c7e10d451e2f5651d34ba2467bf","after":"df4592ec0416aee7c9b758de56d7bd0f6443bf3a","ref":"refs/heads/main","pushedAt":"2024-01-26T21:44:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Type get_class() arg as nonnull in typechecker\n\nSummary: Hopefully this will prevent some code from passing a null.\n\nReviewed By: mdko\n\nDifferential Revision: D53099289\n\nfbshipit-source-id: 2fa9cdda572080d9660a32cadd1f5d97e06918f6","shortMessageHtmlLink":"Type get_class() arg as nonnull in typechecker"}},{"before":"848bbb89c1c484b3e0bffd7d2fd6e3378479dc49","after":"bcbf500d87781c7e10d451e2f5651d34ba2467bf","ref":"refs/heads/main","pushedAt":"2023-12-01T13:23:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Ban varray/darray intrinsic in the typechecker\n\nSummary: ^\n\nReviewed By: vassilmladenov\n\nDifferential Revision: D51563045\n\nfbshipit-source-id: 87a6d5a73507f191407c504d82a0e8eab0c533f7","shortMessageHtmlLink":"Ban varray/darray intrinsic in the typechecker"}},{"before":"3fed9b64cad1c7631b2557153beab1b7b6db0240","after":"848bbb89c1c484b3e0bffd7d2fd6e3378479dc49","ref":"refs/heads/main","pushedAt":"2023-11-14T14:07:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove TANY_MARKER type\n\nSummary: The `TANY_MARKER<_>` type isn't used in www and is used only in `hhi` files to define the `MISSING_RETURN_TYPE` and `MISSING_PROP_TYPE` types. Defining these to be `dynamic` works fine with pessimisation, and with a very little strengthening of types in `hhi` files it works fine even in legacy mode. Note that `getOffset` and `getTimestamp` are now declared to return `int` in the interface `DateTimeInterface`. This is compatible with all implementing classes.\n\nDifferential Revision: D47090958\n\nfbshipit-source-id: d134666dae6fd1897974f639e458b37ea62eec71","shortMessageHtmlLink":"Remove TANY_MARKER type"}},{"before":"9e8ccad37ba51b0f9dbef97386265acc6518fd1e","after":"3fed9b64cad1c7631b2557153beab1b7b6db0240","ref":"refs/heads/main","pushedAt":"2023-11-08T18:34:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Close parentheses in Dict\\pull docstring\n\nSummary: Noticed this while looking at the docs\n\nReviewed By: mdko\n\nDifferential Revision: D51114172\n\nfbshipit-source-id: 3121df485dc30bbb214a9818ea60732b1e64e6d0","shortMessageHtmlLink":"Close parentheses in Dict\\pull docstring"}},{"before":"69ba1682bda3b1180103b4d58ff68ad05e8b7a90","after":"9e8ccad37ba51b0f9dbef97386265acc6518fd1e","ref":"refs/heads/main","pushedAt":"2023-10-13T18:19:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove hack modes from Hack tests\n\nSummary:\nRedo of D50089378 w/o glean test case changes\n```\nfbgr -sl '^<\\?hh ?// ?(strict|partial|decl)$' | grep -P '\\.(php|hhi|exp)$' | grep -P '^hphp/(hsl/tests|hack/test)/' | xargs sed -i -E 's#<\\?hh ?//.*#<?hh#' # need to include .exp for hackfmt tests\nhg revert hphp/hack/test/cst_search/\nhg revert hphp/hack/test/error_formatting_highlighted/\nhg revert hphp/hack/test/full_fidelity/cases/\nhg revert hphp/hack/test/hackfmt/range_tests/\nhg revert hphp/hack/test/facebook/lint/graph/generated_graph_endpoints.php\nhg revert hphp/hack/test/facebook/lint/graph/partially_generated_graph_endpoints.php\n```\n(new this diff)\n```\nhg revert hphp/hack/test/facebook/write_symbol_info\n```\nhttps://fb.alpha.workplace.com/groups/hacklang.eng/permalink/7234143656634187/\n\nReviewed By: madgen\n\nDifferential Revision: D50228788\n\nfbshipit-source-id: 5033b858b2428c36dc190063ef7a5c1aaf71be45","shortMessageHtmlLink":"Remove hack modes from Hack tests"}},{"before":"d9646a60dfa7d2411f9ebacd306dd42b999970a5","after":"69ba1682bda3b1180103b4d58ff68ad05e8b7a90","ref":"refs/heads/main","pushedAt":"2023-10-12T01:45:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert D50089378: Multisect successfully blamed \"D50089378: Remove hack modes from Hack tests\" for test or build failures\n\nSummary:\nThis diff is reverting D50089378\nD50089378: Remove hack modes from Hack tests by viratyosin has been identified to be causing the following test or build failures:\n\nTests affected:\n- [hphp/hack/test/facebook/write_symbol_info:regression_tests - cases/omega_analyser](https://www.internalfb.com/intern/test/844424983077690/)\n\nHere's the Multisect link:\nhttps://www.internalfb.com/multisect/3260372\nHere are the tasks that are relevant to this breakage:\n\nWe're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it.\n\nIf you believe this diff has been generated in error you may Commandeer and Abandon it.\n\nDifferential Revision: D50206182\n\nfbshipit-source-id: 3da6b0aca3e3e4be03884e58d43364408782f0e9","shortMessageHtmlLink":"Revert D50089378: Multisect successfully blamed \"D50089378: Remove ha…"}},{"before":"f14b363d68a717b7ffe02dfaa1746a6bf2d737df","after":"d9646a60dfa7d2411f9ebacd306dd42b999970a5","ref":"refs/heads/main","pushedAt":"2023-10-11T16:24:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove hack modes from Hack tests\n\nSummary:\n```\nfbgr -sl '^<\\?hh ?// ?(strict|partial|decl)$' | grep -P '\\.(php|hhi|exp)$' | grep -P '^hphp/(hsl/tests|hack/test)/' | xargs sed -i -E 's#<\\?hh ?//.*#<?hh#' # need to include .exp for hackfmt tests\nhg revert hphp/hack/test/cst_search/\nhg revert hphp/hack/test/error_formatting_highlighted/\nhg revert hphp/hack/test/full_fidelity/cases/\nhg revert hphp/hack/test/hackfmt/range_tests/\nhg revert hphp/hack/test/facebook/lint/graph/generated_graph_endpoints.php\nhg revert hphp/hack/test/facebook/lint/graph/partially_generated_graph_endpoints.php\n```\n\nThe directories I reverted need special handling, e.g. signatures (wtf) and updates to positional changes\n\nhttps://fb.alpha.workplace.com/groups/hacklang.eng/permalink/7234143656634187/\n\nReviewed By: vsiles\n\nDifferential Revision: D50089378\n\nfbshipit-source-id: 48131fb6d329e5fb9f27810de022a3d119177836","shortMessageHtmlLink":"Remove hack modes from Hack tests"}},{"before":"512323733c57df153fd16c338a5053559e0b056c","after":"f14b363d68a717b7ffe02dfaa1746a6bf2d737df","ref":"refs/heads/main","pushedAt":"2023-09-19T19:06:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"More efficient Keyset\\diff implementation\n\nSummary:\nThis new implementation of Keyset\\diff has some benefits. The new implementation was tested internally at Meta and showed CPU and latency improvements. We needed to test/prove it is an improvement, because we weren't sure of it mainly due to not being certain of the realistic efficiency of `unset`.\n\nThis has few benefits:\n* Less space complexity, because we don't put `$second` and `$rest` into a new keyset via `!$rest ? keyset($second) : union($second, ...$rest);`.\n* Potentially return early if `$first` becomes empty due to removals.\n* This is also potentially more efficient because if `$first` is already a `keyset`, then there will be no iterations over `$first` (if it's not a `keyset`, then converting it to a `keyset` needs to iterate it to do so. The original implementation would iterate `$first` via the `filter` function.\n`$second` and `$rest` are iterated in the old implementation and new implementation (except when there's an early return).\n\nReviewed By: admdikramr\n\nDifferential Revision: D49383300\n\nfbshipit-source-id: 197444cc9770e7e3843376d441efdc978b37b885","shortMessageHtmlLink":"More efficient Keyset\\diff implementation"}},{"before":"61c4b4346e25d7f80814c1f004067a568b0b4a03","after":"512323733c57df153fd16c338a5053559e0b056c","ref":"refs/heads/main","pushedAt":"2023-09-13T16:39:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"More efficient Dict\\flatten implementation\n\nSummary:\nThis updated implementation's benefits:\n* If the first KeyedContainer is a dict, then it reuses the dict rather than inserting key-value pairs one at a time. Reusing (or COW) is more efficient than individual insertions.\n* If $result is still empty at a later iteration through $keyed_containers, the previous bullet point's benefit can apply when the KeyedContainer is a dict (reusing the dict rather than individual insertions).\n\nReviewed By: viratyosin\n\nDifferential Revision: D49159884\n\nfbshipit-source-id: 243f76e80ef3d331131236c9f1a2ea6193842d11","shortMessageHtmlLink":"More efficient Dict\\flatten implementation"}},{"before":"90b6931e835644bb0472dae7beeca5e3ee2674fa","after":"61c4b4346e25d7f80814c1f004067a568b0b4a03","ref":"refs/heads/main","pushedAt":"2023-09-12T00:49:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Improve PseudoRandom\\float\n\nSummary:\nThe previous implementation performed PHP division on integers that would first\ncheck whether the modulo is zero, then perform integer division if it was zero,\nfollowed by a side-exit, because it is rare that the PseudoRandom\\int() returns\nzero (the only value with modulo zero).\n\nInstead, perform the float division.\n\nReviewed By: ricklavoie\n\nDifferential Revision: D49170059\n\nfbshipit-source-id: ce60c05599b5be185c68d5e2a426ed3630d14b63","shortMessageHtmlLink":"Improve PseudoRandom\\float"}},{"before":"354d4e3488ea67cc1e0d3760b707e7348f09113e","after":"90b6931e835644bb0472dae7beeca5e3ee2674fa","ref":"refs/heads/main","pushedAt":"2023-08-18T21:59:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"C\\contains: O(1) instead of O(n) on Sets\n\nSummary: After this change, `C\\contains` called on ConstSets (like Set and ImmSet), will be O(1) instead of O(n).\n\nReviewed By: admdikramr\n\nDifferential Revision: D48415078\n\nfbshipit-source-id: c533aaa0c3835fc88288777e0165eb1e628a9a7c","shortMessageHtmlLink":"C\\contains: O(1) instead of O(n) on Sets"}},{"before":"88c07e8247be612e093d6608eca7d21d59c7891d","after":"354d4e3488ea67cc1e0d3760b707e7348f09113e","ref":"refs/heads/main","pushedAt":"2023-07-11T15:05:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add NoAutoLikes to HSL (4)\n\nSummary:\nMany HSL functions can be given more precise types, avoiding the use of likes.\n\n(We're not yet adding `NoAutoLikes` to higher-order functions because lambda inference has poor interaction with like types.)\n\nDifferential Revision: D47285223\n\nfbshipit-source-id: 99306cff2c42af296063ed69aa82513cfd8208c2","shortMessageHtmlLink":"Add NoAutoLikes to HSL (4)"}},{"before":"fb9417611ba5c86100154d3c87a933dbbd5a4989","after":"88c07e8247be612e093d6608eca7d21d59c7891d","ref":"refs/heads/main","pushedAt":"2023-07-05T19:20:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add NoAutoLikes to HSL (3)\n\nSummary: Many HSL functions can be given more precise types, avoiding the use of likes.\n\nReviewed By: mheiber\n\nDifferential Revision: D47234377\n\nfbshipit-source-id: 7cab82e89405d1ad60c1785083e6a01211febd6d","shortMessageHtmlLink":"Add NoAutoLikes to HSL (3)"}},{"before":"5593152ea797870b2e6682e275d53c72858475e8","after":"fb9417611ba5c86100154d3c87a933dbbd5a4989","ref":"refs/heads/main","pushedAt":"2023-07-05T15:32:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add NoAutoLikes to HSL (1)\n\nSummary: Many HSL functions can be given more precise types, avoiding the use of likes.\n\nDifferential Revision: D47224101\n\nfbshipit-source-id: 517a219ef2181f8c2a013d5feb113581cd39d844","shortMessageHtmlLink":"Add NoAutoLikes to HSL (1)"}},{"before":"a585355fed132902f3997e48c312e97b00418cb5","after":"5593152ea797870b2e6682e275d53c72858475e8","ref":"refs/heads/main","pushedAt":"2023-06-22T18:27:24.105Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove redundant -vAutoload.Enabled options\n\nSummary:\nAutoload.Enabled defaults to true and the option will be deleted soon; remove\nredundant overrides that are just setting the option to it's default.\n\nReviewed By: iwonbigbro\n\nDifferential Revision: D46894749\n\nfbshipit-source-id: 07ca8d15eabd7b7a803959397f645fda8df8ff12","shortMessageHtmlLink":"remove redundant -vAutoload.Enabled options"}},{"before":"21783349a4d98e49ac3bfd099aafad698857e877","after":"a585355fed132902f3997e48c312e97b00418cb5","ref":"refs/heads/main","pushedAt":"2023-06-20T12:04:13.840Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Clarify docblock for Str\\strip_prefix[_l]\n\nSummary:\nLooked all over including our online public docs for the answer to\nthis. It removes the prefix once.\n\nReviewed By: Wilfred\n\nDifferential Revision: D46810327\n\nfbshipit-source-id: 0243d9bc4c4637e510fe01bac37a8c31342e83ee","shortMessageHtmlLink":"Clarify docblock for Str\\strip_prefix[_l]"}},{"before":"3ede33683ef9cd9bf3e7d5cad754e1683dd622fa","after":"21783349a4d98e49ac3bfd099aafad698857e877","ref":"refs/heads/main","pushedAt":"2023-05-19T21:32:39.939Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"use Facts\\subtypes() instead of all_types()\n\nSummary:\nThis removes HSL minitest's dependency on O(repo) facts queries, which\nwe would like to remove. Instead of querying facts for all types and then filtering\njust the test cases, query classes that extend HackTest (there's an API for that!).\n\nReviewed By: oulgen\n\nDifferential Revision: D46024895\n\nfbshipit-source-id: e90087744311238ed8518850e115458145fde4d3","shortMessageHtmlLink":"use Facts\\subtypes() instead of all_types()"}},{"before":"95af8b1a09477a6df1e0b26a6af4453a8a749573","after":"3ede33683ef9cd9bf3e7d5cad754e1683dd622fa","ref":"refs/heads/main","pushedAt":"2023-05-01T09:03:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"migrate straggler tests\n\nReviewed By: ricklavoie\n\nDifferential Revision: D45425200\n\nfbshipit-source-id: bf4830a8fefc9a5c4aa88c099a4bf96797c22fed","shortMessageHtmlLink":"migrate straggler tests"}},{"before":"8b30db619b8ef9c5ac9516dbc96dba3d6cbe4a2e","after":"95af8b1a09477a6df1e0b26a6af4453a8a749573","ref":"refs/heads/main","pushedAt":"2023-04-10T18:43:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix some documentation variable names\n\nSummary:\nI noticed that these variable names in doc comments don't match the actual name of the arguments to the function. Fix it up to reduce any confusion.\n\nCreated from CodeHub with https://fburl.com/edit-in-codehub\n\nReviewed By: periodic1236\n\nDifferential Revision: D41474912\n\nfbshipit-source-id: 1e0b336a01174a13540d848c11783ee79e622b27","shortMessageHtmlLink":"Fix some documentation variable names"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEtF-wTQA","startCursor":null,"endCursor":null}},"title":"Activity · hhvm/hsl"}