From ee9e89ad78945d8afcaa9a6c57eba0b0afcd6ae0 Mon Sep 17 00:00:00 2001 From: Holmes Futrell Date: Fri, 7 Dec 2018 16:52:59 -0800 Subject: [PATCH] Revert "marked boolean operations with "try!"" This reverts commit 165a975adbb541fa866ffaf432f0fa667b1d713a. --- BezierKit/BezierKitTests/PathTests.swift | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/BezierKit/BezierKitTests/PathTests.swift b/BezierKit/BezierKitTests/PathTests.swift index 8b1345db..065ed1de 100644 --- a/BezierKit/BezierKitTests/PathTests.swift +++ b/BezierKit/BezierKitTests/PathTests.swift @@ -342,7 +342,7 @@ class PathTests: XCTestCase { )]) let square1 = createSquare1() let square2 = createSquare2() - let subtracted = try! square1.subtracting(square2) + let subtracted = square1.subtracting(square2) XCTAssertEqual(subtracted.subpaths.count, 1) XCTAssert( componentsEqualAsideFromElementOrdering(subtracted.subpaths[0], expectedResult.subpaths[0]) @@ -364,7 +364,7 @@ class PathTests: XCTestCase { )]) let square1 = createSquare1() let square2 = createSquare2() - let unioned = try! square1.union(square2) + let unioned = square1.union(square2) XCTAssertEqual(unioned.subpaths.count, 1) XCTAssert( componentsEqualAsideFromElementOrdering(unioned.subpaths[0], expectedResult.subpaths[0]) @@ -382,7 +382,7 @@ class PathTests: XCTestCase { )]) let square1 = createSquare1() let square2 = createSquare2() - let intersected = try! square1.intersecting(square2) + let intersected = square1.intersecting(square2) XCTAssertEqual(intersected.subpaths.count, 1) XCTAssert( componentsEqualAsideFromElementOrdering(intersected.subpaths[0], expectedResult.subpaths[0]) @@ -394,7 +394,7 @@ class PathTests: XCTestCase { // the order of the hole is reversed so that it is not contained in the shape when using .winding fill rule let circle = Path(cgPath: CGPath(ellipseIn: CGRect(x: 0, y: 0, width: 3, height: 3), transform: nil)) let hole = Path(cgPath: CGPath(ellipseIn: CGRect(x: 1, y: 1, width: 1, height: 1), transform: nil)) - let donut = try! circle.subtracting(hole) + let donut = circle.subtracting(hole) XCTAssertTrue(donut.contains(CGPoint(x: 0.5, y: 0.5), using: .winding)) // inside the donut (but not the hole) XCTAssertFalse(donut.contains(CGPoint(x: 1.5, y: 1.5), using: .winding)) // center of donut hole } @@ -403,7 +403,7 @@ class PathTests: XCTestCase { // this is a specific test of `subtracting` to ensure that if a path component is entirely contained in the subtracting path that it gets removed let circle = Path(cgPath: CGPath(ellipseIn: CGRect(x: -1, y: -1, width: 2, height: 2), transform: nil)) let biggerCircle = Path(cgPath: CGPath(ellipseIn: CGRect(x: -2, y: -2, width: 4, height: 4), transform: nil)) - XCTAssertEqual(try! circle.subtracting(biggerCircle).subpaths.count, 0) + XCTAssertEqual(circle.subtracting(biggerCircle).subpaths.count, 0) } func testSubtractingEdgeCase1() { @@ -415,7 +415,7 @@ class PathTests: XCTestCase { let circle = Path(cgPath: CGPath(ellipseIn: CGRect(x: 0, y: 0, width: 4, height: 4), transform: nil)) // the circle intersects the rect at (0,2) and (3, 0.26792) ... the last number being exactly 2 - sqrt(3) - let difference = try! rectangle.subtracting(circle) + let difference = rectangle.subtracting(circle) XCTAssertEqual(difference.subpaths.count, 1) XCTAssertFalse(difference.contains(CGPoint(x: 2.0, y: 2.0))) } @@ -434,7 +434,7 @@ class PathTests: XCTestCase { square2CGPath.closeSubpath() let square2 = Path(cgPath: square2CGPath) - let result = try! square1.subtracting(square2) + let result = square1.subtracting(square2) let expectedResultCGPath = CGMutablePath() expectedResultCGPath.move(to: CGPoint.zero) @@ -474,7 +474,7 @@ class PathTests: XCTestCase { XCTAssertTrue(path.contains(CGPoint(x: 1.5, y: 1.25), using: .winding)) XCTAssertFalse(path.contains(CGPoint(x: 1.5, y: 1.25), using: .evenOdd)) - let result = try! path.crossingsRemoved() + let result = path.crossingsRemoved() XCTAssertEqual(result.subpaths.count, 1) XCTAssertTrue(componentsEqualAsideFromElementOrdering(result.subpaths[0], expectedResult.subpaths[0])) @@ -483,7 +483,7 @@ class PathTests: XCTestCase { cgPathAlt.addLines(between: Array(points[3.. 0.0 } let cleanPath = Path(subpaths: [PathComponent(curves: curves2)]) - let result = try! cleanPath.crossingsRemoved(threshold: 1.0e-4) + let result = cleanPath.crossingsRemoved(threshold: 1.0e-4) // check that the inner loop was eliminated by checking the winding count in the middle XCTAssertEqual(result.windingCount(CGPoint(x: 0.5, y: 1)), 1)