Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerendering List Replaces First ListItem #307

Open
cwarden opened this issue Feb 29, 2024 · 1 comment
Open

Rerendering List Replaces First ListItem #307

cwarden opened this issue Feb 29, 2024 · 1 comment

Comments

@cwarden
Copy link

cwarden commented Feb 29, 2024

When a List is rerendered, the first listitem is replaced. If it has focus, it loses focus. The other listitems don't have this problem.

Here's an example using the todomvc application.

vecty-rerender-list-bug
@cwarden
Copy link
Author

cwarden commented Feb 29, 2024

I don't understand the code yet, but the problem appears to be in reconcileChildren, in which stableKey doesn't get set.

36a9ad6 "fixes" the issue.

cwarden added a commit to octoberswimmer/masc that referenced this issue Mar 8, 2024
@cwarden
WIP: Fix Rerendering of First List Item
3f09430 
See hexops/vecty#307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cwarden