Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiation params of generic functions don't get prefixed with the package name #95

Open
rflect-ch opened this issue Nov 11, 2024 · 0 comments

Comments

@rflect-ch
Copy link

If I try to wrap a gRPC server which is generated with generic types, instantiation params on the generic types are not prefixed with package in the wrapper.

Provisional example:

type BadgesServer interface {
       Subscribe(*SubscribeRequest, grpc.ServerStreamingServer[BadgeEvent]) error
}

BadgeEvent is a proto message defined in the same package as the BadgeServer.

In this case gowrap will generate wrapper where BadgeEvent will not be prefixed with its package but will just stay as BadgeEvent. This way it reports an error because as expected the target package doesn't have the type defined.

I have fixed it by disabling generic code generation in protos, but would be nice to have support for this properly in gowrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant