Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit STACK check #76

Open
edmorley opened this issue Apr 27, 2021 · 0 comments
Open

Add explicit STACK check #76

edmorley opened this issue Apr 27, 2021 · 0 comments

Comments

@edmorley
Copy link
Member

This buildpack currently doesn't validate whether it supports the current $STACK.

This means if someone pins to an old SHA of the buildpack or forks the buildpack, then later a new stack is introduced, they get an error like cp: cannot stat 'bin/nginx-heroku-18': No such file or directory (in the case of older releases), or more recently they'd get a tar error.

Example support ticket:
https://heroku.support/985441

Whilst nothing can be done about older releases now, it would be good to add an explicit stack check to make this failure mode more obvious in the future :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant