Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you open for a PR that allows an extra module to be enabled via an ENV var (default off)? #111

Open
jackkinsella opened this issue Dec 12, 2022 · 2 comments

Comments

@jackkinsella
Copy link

jackkinsella commented Dec 12, 2022

TLDR: If I created a PR that made the --with-http_stub_status_module module possible to include via an ENV var (e.g. NGINX_WITH_X, would you accept this?

Background:

We want to log the active number of worker connections in nginx in order to proactively keep on top of potential worker resource starvation. The --with-http_stub_status_module module makes the $number_connections variable available.

The suggested solution of going with a fork is not worth the risk of potentially missing critical upstream changes to the buildpack.

Obviously even better would be if this small module were included by default in the BuildPack (it's default in certain installations, e.g. via Homebrew on macos). But I understand if you would prefer not to add default modules.

@rbrisita
Copy link

Or add the ability to read in scripts/build_nginx that contains added build configuration options.

@rbrisita
Copy link

Easiest implementation PR found here: heroku/heroku-buildpack-php#598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants