Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover whole region - landscape only. #97

Open
fillilutten opened this issue Jan 18, 2021 · 7 comments
Open

Cover whole region - landscape only. #97

fillilutten opened this issue Jan 18, 2021 · 7 comments

Comments

@fillilutten
Copy link

fillilutten commented Jan 18, 2021

I would like to display landscape photos on the whole region but portrait is working fine.

@aneaville
Copy link
Collaborator

I think a bit of extra information would be helpful, as I'm not sure I understand.
Do you have your 'screen' horizontal or vertical? Could you share your configuration of this module?

-Andrew

@fillilutten
Copy link
Author

I'm sorry for the really sparse info.
A horizontal screen, 1024x768. The images that are in portrait shows up just perfect but the landscape images, due to aspect ratio, doesn't cover the whole screen and makes most of them letterboxed with small black bars above and under the photo. I could live some cropping to not have them letterboxed since so little would get cropped out.

Bonus: Here's my setup. Your module made my fantasy about a Google photo digital frame real and got me into MM. Thanks! https://imgur.com/a/NGXxgUX

@ChrisAcrobat
Copy link
Collaborator

I think that would be possible to fix with some custom CSS. Do you need help with getting it sorted out?

@ChrisAcrobat
Copy link
Collaborator

I think this is what you need:

#GPHOTO_CURRENT {
	background-size:cover;
}

@fillilutten
Copy link
Author

fillilutten commented Jan 18, 2021 via email

@fillilutten
Copy link
Author

I've tried to make it work with this (https://developer.mozilla.org/en-US/docs/Web/CSS/@media/orientation) but can't get it to work.

@aneaville
Copy link
Collaborator

I'm going through all the old open issues. Are you still working on this?

I'm thinking the original proposal is the best solution.
#GPHOTO_CURRENT {
background-size:cover;
}
You mention it cropped the images too much. I'm guessing the pi is displaying an area larger than the screen actually is. Is this possible? Can you change the pi's display settings to bring the displayed area closer to the screen you have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants