Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join should act like upload #279

Open
burritojustice opened this issue Oct 13, 2020 · 0 comments
Open

join should act like upload #279

burritojustice opened this issue Oct 13, 2020 · 0 comments

Comments

@burritojustice
Copy link
Contributor

join currently expects a space ID that contains the geometries to be joined to a csv data table via virtual spaces -- it generates a space ID for the csv data table and a virtual space ID.

There is no way for join to update an existing data space to update the virtual space. While you can upload to the space, you need to specify --nocoords. This is also inconsistent with upload that either adds data to a specified space ID, or generates one if not present.

We should change join to accept a space ID in order to update the space containing the csv data table, and specify the geometry space ID using an argument

here xyz join -f my.csv --target space_with_geometries
or perhaps
here xyz join -f my.csv --geom space_with_geometries -i important_property

If a space ID is present, this could either be the space ID of the virtual space, or the space ID of the data table (the second space in the virtual space argument). Need to discuss.

here xyz join spaceID -f data_update.csv

we also need to consider the interactive mode for join

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant