-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade highlight.js dependency to v10 #14
Comments
At a glance I think this should be pretty straightforward. |
I would love it if you could update this to version 10 of highlight.js. I'm starting to get folks logging issues on my repo due to this dependency 😢 - If there anything I can do to help please let me know. 🙏🏻 |
Unfortunately I don't have time to make PRs for every downstream library but if someone just bumped the dependencies here and then played around a bit that might get them really far. It's always hard to call these things with just a glance but our public API between v9 -> v10 was actually super stable. You could read the Version 10 release notes to see what changed, but for many, many people upgrading was super simple - despite many small breaking changes. We no longer support IE11 is the big change that might bite some people. (though that wouldn't matter if you were running this on the server-side). |
Wrote a very tiny guide: |
Hey @jonschlinkert / @doowb / @almeidap Is there any chance that you could take a look at this issue, please? 🙏 |
@joshgoebel @DannyDainton @almeidap |
Hey, There are 2 Pull requests that request to bump to v10: @jonschlinkert @doowb @almeidap Could you help to merge it to address the security risk? |
👋 Hi @jonschlinkert @doowb |
Hello Team,
This is problem about the latest dependency about highlight.js related here: highlightjs/highlight.js#2877
Is it possible to upgrade you highlight dependencies to v10 please :)
See you
Romain
The text was updated successfully, but these errors were encountered: