Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure eof newline option #35

Open
hayd opened this issue Apr 8, 2014 · 2 comments
Open

ensure eof newline option #35

hayd opened this issue Apr 8, 2014 · 2 comments
Labels
Milestone

Comments

@hayd
Copy link
Owner

hayd commented Apr 8, 2014

I think atm new line is always added to eof (if missing) potentially this is a bug in autopep8, but we should have this as an option...

This is much less a problem than it was in earlier versions (where this counted as an additional radius to apply autopep8 to on a second iteration... I think it's ok now - should add test)

@hayd hayd added this to the someday milestone Apr 8, 2014
@hayd hayd added the question label Apr 8, 2014
@hayd hayd changed the title ensure eof newline ensure eof newline option Apr 8, 2014
@schodge
Copy link
Contributor

schodge commented Jun 10, 2014

Less an issue, more an enhancement suggestion for a future rev, for the

  --ignore errors       do not fix these errors/warnings (default: E24)
  --select errors       fix only these errors/warnings (e.g. E4,W)

could we keep a config file of settings here - preferably on a per-project basis so projects can set their desired style? E.g., in Anconda on sublime, the config file includes:

    /*
        A list of pep8 error numbers to ignore.
        The list of error codes is in this file: https://github.com/jcrocholl/pep8/blob/master/pep8.py.
        Search for "Ennn:", where nnn is a 3-digit number.
    */
    "pep8_ignore":
    ["E301", "E302"
    ],

    // Maximum line length for pep8
    "pep8_max_line_length": 79,

    // Set this to true to turn pep257 checking on
    "pep257": false,

    /*
        A list of pep257 error numbers to ignore.
        The list can be found here: https://github.com/GreenSteam/pep257/#error-codes
        D209 Multi-line docstring should end with 1 blank line is ignored by
        default as it has been deprecated.
    */
    "pep257_ignore":
    [
        "D209"
    ],

@hayd
Copy link
Owner Author

hayd commented Jun 10, 2014

definitely, see #30. I think this ought/has to be done at the same time as autopep8 (which doesn't do this either).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants