Add docs for shutting down sockets in a threaded scenario #548
Conversation
|
|
|
I think the problem with close is that there are two places where you would want to do that. Let's say you have a background thread that's listening on the socket. Given that the other side might also close it, there's probably a This makes a few assumptions about the way the operating system works, but it doesn't seem unrealistic to me. Using shutdown from the outside and waiting for the bracketed close to do it's thing seems safer. |
|
I'm not sure I understand your programming model correctly but the top of the manual says:
And when |
|
I'm basically building a proxy with two sockets and one thread for each. One threads reads from socket A and writes to B, the other one does it the other way around. As far as I understand it, this pattern is explicitly covered by the part you quoted. I missed that multiple calls to close are safe, thank you for pointing it out. I'll rewrite this to suggest I get that this might feel a bit unnecessary, but given the amount of pitfalls low-level network programming has, I think it would be very useful to users to be explicitly shown a way to do this that is safe. |
| @@ -100,6 +100,44 @@ | |||
| -- unexpected things would happen. There is one exception for multiple | |||
There was a problem hiding this comment.
This existing sentence is not good.
unexpected things, what's that referring to?
This needs explanation.
| @@ -100,6 +100,44 @@ | |||
| -- unexpected things would happen. There is one exception for multiple | |||
| -- threads vs a single 'Socket': one thread reads data from a 'Socket' | |||
| -- only and the other thread writes data to the 'Socket' only. | |||
| -- | |||
| -- The preferred way to terminate a thread that is blocked on a call to | |||
| -- 'Network.Socket.ByteString.recv' is to use 'shutdown' | |||
There was a problem hiding this comment.
The immediate question this poses:
Why this, instead of just throwing an exception to the thread that's blocked on recv?
That would be the most natural to me, as that's how e.g. async does it.
recv is implemented in terms of threadWaitRead, so throwTo to it should work fine and interrupt it, shouldn't it?
Then, if you want your app to do a graceful shutdown, it can do
bracket createConnection gracefulClose $ -- ... code using recv ...
Closes #545, see discussion there.
Basically, this is the documentation that I think would have helped me a few days ago.
I'm very much open to changing all it. The code example is a bit more complex than what I would like, but I thought it's better to show the situation where I needed it than to make it very simple.